Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pops): Main Challenger Binary Logic #5617

Merged
merged 2 commits into from
May 5, 2023
Merged

Conversation

refcell
Copy link
Contributor

@refcell refcell commented May 4, 2023

Description

Adds main logic required to run an op-challenger binary stub.

Metadata

Fixes CLI-3944

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

⚠️ No Changeset found

Latest commit: a468978

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit a468978
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645453e5465c5600077e8c4d

@refcell refcell marked this pull request as ready for review May 4, 2023 21:41
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We really need to start building tests for this module though. The more code we add before starting to write tests, the harder it will be to add them later because the design isn't testable.

@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 8053be9 into develop May 5, 2023
8 of 9 checks passed
@OptimismBot OptimismBot deleted the pops/main/challenger branch May 5, 2023 01:10
@mergify mergify bot removed the on-merge-train label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants