Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxyd/fix: rewrite should support BlockNumberOrHash #5618

Merged
merged 3 commits into from
May 4, 2023

Conversation

felipe-op
Copy link
Member

@felipe-op felipe-op commented May 4, 2023

Description

Block numbers are sometimes hashes, and the marshalling decides based on the contents. We need to support accepting BlockNumberOrHash in tag rewrites.

Example request:

{"auth":"none","body":"{\"jsonrpc\":\"2.0\",\"id\":12,\"method\":\"eth_getStorageAt\",\"params\":[\"0xae851f927ee40de99aabb7461c00f9622ab91d60\",\"0x65a7ed542fb37fe237fdfbdd70b31598523fe5b32879e307bae27a0bd9581c08\",\"0x1c4840bcb3de3ac403c0075b46c2c47d4396c5b624b6e1b2874ec04e8879b483\"]}","lvl":"info","msg":"Raw RPC request","req_id":"06d2e2e291ce6528958c","t":"2023-05-04T21:45:24.548498655Z"}

Tests

Add new test to cover this code path

Invariants

n/a

Additional context

This is part of the project Consensus Aware RPC Proxy: https://www.notion.so/oplabs/Consensus-Aware-RPC-Proxy-0138e029af814e4cbca2740c7888e02d

Tag rewrite PR: #5586

Fixes

TODOs

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

⚠️ No Changeset found

Latest commit: 1026a46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 1026a46
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645440b6977175000902976d

@felipe-op felipe-op requested a review from mslipper May 4, 2023 22:37
@felipe-op felipe-op changed the title rewrite should support blockorhash proxyd/fix: rewrite should support BlockNumberOrHash May 4, 2023
@felipe-op felipe-op marked this pull request as ready for review May 4, 2023 23:32
@felipe-op felipe-op requested a review from a team as a code owner May 4, 2023 23:32
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit bc2a984 into develop May 4, 2023
8 of 9 checks passed
@OptimismBot OptimismBot deleted the felipe/rewrite-blockorhash branch May 4, 2023 23:36
@mergify mergify bot removed the on-merge-train label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants