Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(op-node): Stub Mainnet Chain Config #5646

Merged
merged 2 commits into from May 9, 2023
Merged

feat(op-node): Stub Mainnet Chain Config #5646

merged 2 commits into from May 9, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented May 8, 2023 •
edited

Description

As per migration discussion today, this introduces a stubbed out Mainnet chain config so day-off in-place diff is reduced.

Metadata

Fixes CLI-3964

@refcell refcell self-assigned this May 8, 2023
@refcell refcell requested a review from a team as a code owner May 8, 2023 19:18
@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023 •
edited

⚠️ No Changeset found

Latest commit: 9d457f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 8, 2023 •
edited

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 9d457f8
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645999be922ed2000876cd56

@refcell refcell force-pushed the refcell/impute/mainnetchains branch from 9f9ae49 to c3457b3 Compare May 8, 2023 19:26
maurelian
maurelian reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note for now that non-zero values in this should match the ones in mainnet.json.

@refcell refcell requested a review from maurelian May 8, 2023 23:11
trianglesphere
trianglesphere approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Contributor

mergify bot commented May 9, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 9, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 9, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 6d4f525 into develop May 9, 2023
78 of 79 checks passed
@OptimismBot OptimismBot deleted the refcell/impute/mainnetchains branch May 9, 2023 01:09
@mergify mergify bot removed the on-merge-train label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trianglesphere trianglesphere trianglesphere approved these changes

@tynes tynes Awaiting requested review from tynes

@maurelian maurelian Awaiting requested review from maurelian

Assignees

@refcell refcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@refcell @trianglesphere @maurelian @OptimismBot