Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strings package to check for a prefix #5653

Merged
merged 1 commit into from
May 10, 2023
Merged

Use strings package to check for a prefix #5653

merged 1 commit into from
May 10, 2023

Conversation

trianglesphere
Copy link
Contributor

Description

Use a built in function rather than manually slicing strings.

@trianglesphere trianglesphere requested a review from a team as a code owner May 9, 2023 00:49
@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 68c9c9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere trianglesphere requested review from ajsutton and refcell and removed request for mslipper May 9, 2023 00:49
@netlify
Copy link

netlify bot commented May 9, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 68c9c9e
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645c0127e875dc000878f5d2

refcell
refcell approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG once @ajsutton's suggestion is impl'd

@OptimismBot OptimismBot merged commit 45fa82e into develop May 10, 2023
@OptimismBot OptimismBot deleted the jg/cleanup branch May 10, 2023 23:20
@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

@refcell refcell refcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trianglesphere @ajsutton @refcell @OptimismBot