Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proxyd): prevent direct access to backend state struct in consensus poller #5664

Merged
merged 3 commits into from
May 9, 2023

Conversation

felipe-op
Copy link
Member

Description

This patch refactors the backend state access in consensus poller to avoid direct access to the struct.

Tests

go test ./...

Invariants

n/a

Additional context

n/a

Metadata

TODOs

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

⚠️ No Changeset found

Latest commit: 1ed8717

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 1ed8717
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645aa46fd5bdb80008cef0ea

@felipe-op felipe-op changed the title Felipe/fix bs access fix(proxyd): prevent direct access to backend state struct in consensus poller May 9, 2023
@felipe-op felipe-op requested a review from mslipper May 9, 2023 19:08
@felipe-op felipe-op changed the title fix(proxyd): prevent direct access to backend state struct in consensus poller refactor(proxyd): prevent direct access to backend state struct in consensus poller May 9, 2023
@felipe-op felipe-op marked this pull request as ready for review May 9, 2023 19:41
@felipe-op felipe-op requested a review from a team as a code owner May 9, 2023 19:41
@mergify
Copy link
Contributor

mergify bot commented May 9, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 9, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 9, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 6188ff5 into develop May 9, 2023
8 of 9 checks passed
@OptimismBot OptimismBot deleted the felipe/fix-bs-access branch May 9, 2023 19:55
@mergify mergify bot removed the on-merge-train label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants