Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dai to indexer #5741

Merged
merged 2 commits into from
May 24, 2023
Merged

feat: Add dai to indexer #5741

merged 2 commits into from
May 24, 2023

Conversation

roninjin10
Copy link
Contributor

We had this commented out before. I could not find a good reason why. It's been commented out since genesis 0838522

@roninjin10 roninjin10 requested a review from a team as a code owner May 18, 2023 23:58
@changeset-bot
Copy link

changeset-bot bot commented May 18, 2023

⚠️ No Changeset found

Latest commit: 8be4a93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@roninjin10 roninjin10 mentioned this pull request May 18, 2023
@roninjin10
Copy link
Contributor Author

roninjin10 commented May 18, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mergify mergify bot added the A-indexer Area: indexer label May 18, 2023
@roninjin10 roninjin10 marked this pull request as draft May 19, 2023 00:01
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #5741 (abb4fff) into develop (6066c16) will decrease coverage by 3.06%.
The diff coverage is n/a.

❗ Current head abb4fff differs from pull request most recent head 8be4a93. Consider uploading reports for the commit 8be4a93 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5741      +/-   ##
===========================================
- Coverage    42.34%   39.29%   -3.06%     
===========================================
  Files          461      290     -171     
  Lines        29862    24486    -5376     
  Branches       876        0     -876     
===========================================
- Hits         12646     9622    -3024     
+ Misses       16225    13969    -2256     
+ Partials       991      895      -96     
Flag Coverage Δ
bedrock-go-tests 39.29% <ø> (-0.47%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 186 files with indirect coverage changes

@roninjin10 roninjin10 marked this pull request as ready for review May 19, 2023 01:01
@roninjin10 roninjin10 marked this pull request as draft May 19, 2023 01:04
@tynes
Copy link
Contributor

tynes commented May 19, 2023

Generally looks good to me

Copy link
Contributor

@tarunkhasnavis tarunkhasnavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@roninjin10 roninjin10 marked this pull request as ready for review May 24, 2023 05:10
Base automatically changed from willc/kovan to develop May 24, 2023 15:37
Copy link
Contributor

@hamdiallam hamdiallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange it was commented out. It's not commented out on L1

@mergify
Copy link
Contributor

mergify bot commented May 24, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 24, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 8be4a93
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/646e384ae004eb0008dc712a

@mergify
Copy link
Contributor

mergify bot commented May 24, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 12e782d into develop May 24, 2023
75 of 79 checks passed
@OptimismBot OptimismBot deleted the willc/dai branch May 24, 2023 16:20
@mergify mergify bot removed the on-merge-train label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-indexer Area: indexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants