-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dai to indexer #5741
feat: Add dai to indexer #5741
Conversation
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5741 +/- ##
===========================================
- Coverage 42.34% 39.29% -3.06%
===========================================
Files 461 290 -171
Lines 29862 24486 -5376
Branches 876 0 -876
===========================================
- Hits 12646 9622 -3024
+ Misses 16225 13969 -2256
+ Partials 991 895 -96
Flags with carried forward coverage won't be shown. Click here to find out more. |
Generally looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange it was commented out. It's not commented out on L1
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
✅ Deploy Preview for opstack-docs canceled.
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
We had this commented out before. I could not find a good reason why. It's been commented out since genesis 0838522