-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts-bedrock: simplify hh config for mainnet #5857
Conversation
hardhat barfs if we pass the zero key in, not sure why we do it everywhere. default to using the 'test test ...' key at index 0 if the private key is not passed instead. this is useful for mainnet migration rehearsals and since the mainnet contracts have already been deployed, unlikely this will be used again and if used again the private key env var MUST be passed anyways
|
✅ Deploy Preview for opstack-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
FYI @tynes you're just missing a |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5857 +/- ##
===========================================
- Coverage 42.95% 42.43% -0.52%
===========================================
Files 478 390 -88
Lines 30783 28914 -1869
Branches 877 509 -368
===========================================
- Hits 13224 12271 -953
+ Misses 16533 15664 -869
+ Partials 1026 979 -47
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
hardhat barfs if we pass the zero key in, not sure why we do it everywhere. default to using the 'test test ...' key at index 0 if the private key is not passed instead. this is useful for mainnet migration rehearsals and since the mainnet contracts have already been deployed, unlikely this will be used again and if used again the private key env var MUST be passed anyways