Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts-bedrock: simplify hh config for mainnet #5857

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 1, 2023

Description

hardhat barfs if we pass the zero key in, not sure why we do it everywhere. default to using the 'test test ...' key at index 0 if the private key is not passed instead. this is useful for mainnet migration rehearsals and since the mainnet contracts have already been deployed, unlikely this will be used again and if used again the private key env var MUST be passed anyways

hardhat barfs if we pass the zero key in, not sure why we
do it everywhere. default to using the 'test test ...' key
at index 0 if the private key is not passed instead.
this is useful for mainnet migration rehearsals and since
the mainnet contracts have already been deployed, unlikely
this will be used again and if used again the private key
env var MUST be passed anyways
@tynes tynes requested a review from a team as a code owner June 1, 2023 17:29
@tynes tynes requested a review from refcell June 1, 2023 17:29
@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

⚠️ No Changeset found

Latest commit: 5c6ad2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit 5c6ad2b
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6482020a0d0f4500081eab2c
😎 Deploy Preview https://deploy-preview-5857--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@refcell
Copy link
Contributor

refcell commented Jun 2, 2023

FYI @tynes you're just missing a npx prettier --write hardhat.config.ts run for this to pass

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #5857 (5c6ad2b) into develop (9c3103f) will decrease coverage by 0.52%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5857      +/-   ##
===========================================
- Coverage    42.95%   42.43%   -0.52%     
===========================================
  Files          478      390      -88     
  Lines        30783    28914    -1869     
  Branches       877      509     -368     
===========================================
- Hits         13224    12271     -953     
+ Misses       16533    15664     -869     
+ Partials      1026      979      -47     
Flag Coverage Δ
bedrock-go-tests 40.55% <ø> (-0.01%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests 98.86% <ø> (ø)
core-utils-tests ?
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 29.33% <ø> (ø)
sdk-tests 39.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 90 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 2fdcbd5 into develop Jun 8, 2023
85 of 86 checks passed
@OptimismBot OptimismBot deleted the feat/simple-hh-mainnet-config branch June 8, 2023 16:46
@mergify mergify bot removed the on-merge-train label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants