Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-batcher: Add metrics for pending L2 transaction data size #5865

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

trianglesphere
Copy link
Contributor

Description

Same as the previous version. Has been tested on the internal devnet.

@trianglesphere trianglesphere requested a review from a team as a code owner June 2, 2023 00:00
@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2023

⚠️ No Changeset found

Latest commit: bfbede0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere trianglesphere removed the request for review from mslipper June 2, 2023 00:00
@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit bfbede0
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6482ea55263a510008f3d460

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #5865 (bfbede0) into develop (d69cb12) will increase coverage by 10.25%.
The diff coverage is 13.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5865       +/-   ##
============================================
+ Coverage    30.38%   40.63%   +10.25%     
============================================
  Files          457      319      -138     
  Lines        29023    26092     -2931     
  Branches       877        0      -877     
============================================
+ Hits          8818    10603     +1785     
+ Misses       19644    14513     -5131     
- Partials       561      976      +415     
Flag Coverage Δ
bedrock-go-tests 40.63% <13.33%> (+15.23%) ⬆️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-batcher/metrics/metrics.go 0.00% <0.00%> (ø)
op-batcher/batcher/channel_manager.go 82.19% <100.00%> (+0.16%) ⬆️
op-batcher/metrics/noop.go 53.33% <100.00%> (+7.17%) ⬆️

... and 265 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 7af83e4 into develop Jun 9, 2023
84 of 85 checks passed
@OptimismBot OptimismBot deleted the jg/batcher_metrics branch June 9, 2023 09:16
@mergify mergify bot removed the on-merge-train label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants