Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-legacy L2 deployments with optional governance #5986

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Support non-legacy L2 deployments with optional governance #5986

merged 3 commits into from
Jun 14, 2023

Conversation

roberto-bayardo
Copy link
Collaborator

Extend the genesis utilities to support fresh (no migration requirement) L2 deployments, with or without governance token.

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c47fe5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 11, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit c47fe5d
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/648907b39159cf00087f87e6

@roberto-bayardo roberto-bayardo changed the title Optional governance Support non-legacy L2 deployments with optional governance Jun 11, 2023
@roberto-bayardo roberto-bayardo force-pushed the optional-governance branch 3 times, most recently from d8bed69 to 78b43d7 Compare June 11, 2023 22:59
@roberto-bayardo roberto-bayardo force-pushed the optional-governance branch 3 times, most recently from a3b3975 to 227116f Compare June 12, 2023 15:12
@tynes
Copy link
Contributor

tynes commented Jun 12, 2023

Are you ok with us merging #5996 to help reduce the diff of this PR? Will make it easier to review for correctness

@roberto-bayardo
Copy link
Collaborator Author

Are you ok with us merging #5996 to help reduce the diff of this PR? Will make it easier to review for correctness

yes, let me do that and make another pass over this to see what I can clean up / simplfiy.

@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Hey @roberto-bayardo! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 12, 2023
@mergify mergify bot removed the conflict label Jun 12, 2023
@roberto-bayardo
Copy link
Collaborator Author

roberto-bayardo commented Jun 12, 2023 •
edited
Loading

Updated this PR to merge #5996 and make it quite a bit more surgical, e.g. it now only excludes a single "legacy" contract (LegacyWETH).

Still TODO: change the config to a boolean to enable/disable governance.

@roberto-bayardo roberto-bayardo force-pushed the optional-governance branch 2 times, most recently from 47d2a9a to 0651d3b Compare June 12, 2023 22:09
@tynes
Copy link
Contributor

tynes commented Jun 12, 2023

Amazing! This diff is so much more manageable

@roberto-bayardo roberto-bayardo marked this pull request as ready for review June 13, 2023 01:29
@roberto-bayardo roberto-bayardo requested review from a team as code owners June 13, 2023 01:29
@roberto-bayardo roberto-bayardo force-pushed the optional-governance branch 5 times, most recently from 902d6fe to 3eb9ab9 Compare June 13, 2023 18:48
@roberto-bayardo roberto-bayardo force-pushed the optional-governance branch 7 times, most recently from 0848c9c to d09a328 Compare June 13, 2023 23:41
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit c3cff50 into ethereum-optimism:develop Jun 14, 2023
70 of 72 checks passed
@mergify mergify bot removed the on-merge-train label Jun 14, 2023
@roberto-bayardo roberto-bayardo mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes tynes approved these changes

@mslipper mslipper Awaiting requested review from mslipper mslipper is a code owner automatically assigned from ethereum-optimism/go-reviewers

@smartcontracts smartcontracts Awaiting requested review from smartcontracts smartcontracts is a code owner automatically assigned from ethereum-optimism/contract-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roberto-bayardo @tynes @OptimismBot