Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: fix chain ID/hash check errors #6004

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

protolambda
Copy link
Contributor

Description

Common mistake is to connect to the wrong RPC. But the logs were making this very confusing, since got/expected values were swapped and formatted incorrectly. This fixes that.

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

⚠️ No Changeset found

Latest commit: b857ed6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit b857ed6
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6488b5aa1ea6a20008c034c3

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #6004 (b857ed6) into develop (c2f6c68) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6004      +/-   ##
===========================================
+ Coverage    44.27%   44.49%   +0.22%     
===========================================
  Files          412      299     -113     
  Lines        26340    23027    -3313     
  Branches       686        0     -686     
===========================================
- Hits         11662    10246    -1416     
+ Misses       13675    11827    -1848     
+ Partials      1003      954      -49     
Flag Coverage Δ
bedrock-go-tests 44.49% <100.00%> (+0.01%) ⬆️
common-ts-tests ?
contracts-bedrock-tests ?
core-utils-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/rollup/types.go 82.02% <100.00%> (ø)

... and 116 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit dee1d2f into develop Jun 13, 2023
74 of 75 checks passed
@OptimismBot OptimismBot deleted the fix-chain-id-log branch June 13, 2023 18:45
@mergify mergify bot removed the on-merge-train label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants