op-node: handle -32600 receipts err code, and always fallback to err msg #6019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for opstack-docs canceled.
|
protolambda
force-pushed
the
receipt-fallback-check
branch
from
43e20e9
to
79109a4
Compare
|
update: lint issue, fixed now |
trianglesphere
approved these changes
Jun 14, 2023
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alchemy returns
-32600(generic) instead of-32601("unknown method") for unsupported RPC methods. We should make the op-node fall-back to the wider-supported receipt fetching methods when it hits this error, to avoid sync stalling. It already will log warnings about it falling back, and tries the advanced receipt fetching methods later again.