Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: update to urfave v2, merge endpoint-monitor and op-heartbeat into main go module #6098

Merged
merged 6 commits into from
Jun 21, 2023

Conversation

protolambda
Copy link
Contributor

Description

  • Merge endpoint-monitor into root Go module
    • Updated to no longer depend on legacy l2geth.
  • Merge op-heartbeat into root Go module
  • Update all main Go-mod packages to urfave CLI v2.
    • op-batcher
    • op-bootnode
    • op-challenger
    • op-heartbeat
    • op-node
    • op-program/host
    • op-proposer
    • op-service
    • op-signer/client
    • op-wheel

Cannon + Geth are already using urfave CLI v2.

With this upgrade, in separate later PRs, we can improve op-service without complicating a later v2 migration, and utilize the improved context/shutdown functionality of urfave CLI v2.

In practice, most of the v2 CLI migration changes are:

  • commands/flags now with pointers
  • EnvVars instead of EnvVar
  • import-path updates

Tests

No functionality changes

Metadata

Fix CLI-3946

@protolambda protolambda requested review from a team as code owners June 21, 2023 18:47
@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023

⚠️ No Changeset found

Latest commit: d6f5695

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit d6f5695
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64937d3ba5d7ca000898fb1d

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the flipped CheckRequired is the reason the tests are failing.
Lots of code to review, but it was pretty straightforwards.

op-node/flags/flags.go Outdated Show resolved Hide resolved
op-service/log/cli.go Show resolved Hide resolved
op-batcher/compressor/cli.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #6098 (f25b2d8) into develop (eba6605) will increase coverage by 0.73%.
The diff coverage is 59.00%.

❗ Current head f25b2d8 differs from pull request most recent head d6f5695. Consider uploading reports for the commit d6f5695 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6098      +/-   ##
===========================================
+ Coverage    44.72%   45.46%   +0.73%     
===========================================
  Files          304      434     +130     
  Lines        23290    28002    +4712     
  Branches         0      688     +688     
===========================================
+ Hits         10417    12731    +2314     
- Misses       11914    14237    +2323     
- Partials       959     1034      +75     
Flag Coverage Δ
bedrock-go-tests 44.67% <59.00%> (-0.06%) ⬇️
cannon-go-tests 61.71% <ø> (?)
common-ts-tests 26.82% <ø> (?)
contracts-bedrock-tests 59.25% <ø> (?)
core-utils-tests 48.47% <ø> (?)
fault-detector-tests 29.51% <ø> (?)
sdk-tests 39.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-batcher/batcher/batch_submitter.go 0.00% <ø> (ø)
op-batcher/batcher/config.go 0.00% <0.00%> (ø)
op-batcher/cmd/doc/cmd.go 0.00% <ø> (ø)
op-batcher/cmd/main.go 0.00% <0.00%> (ø)
op-challenger/cmd/main.go 12.50% <0.00%> (ø)
op-challenger/cmd/watch/cmd.go 0.00% <ø> (ø)
op-challenger/config/config.go 36.36% <0.00%> (ø)
op-challenger/config/logging.go 0.00% <ø> (ø)
op-node/cmd/batch_decoder/main.go 0.00% <0.00%> (ø)
op-node/cmd/doc/cmd.go 0.00% <ø> (ø)
... and 28 more

... and 137 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit a205f8e into develop Jun 21, 2023
72 of 73 checks passed
@OptimismBot OptimismBot deleted the cli-update branch June 21, 2023 23:00
@mergify mergify bot removed the on-merge-train label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants