Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs/op-stack): Changes related to the move from hardhat to foundry #6147

Merged
merged 7 commits into from
Jun 26, 2023

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Jun 26, 2023

  • Restrict the not for production warning. It's not cast wallet that is insecure, just cast wallet new.
  • Fix numbering in #configure-your-network
  • Add warning related to direnv installation
  • Remove no longer relevant request (to replace , which no longer appears in a command line)
  • Add creating a deployment directory for getting-started
  • Fix the L2OO_ADDR table line
  • Update file name for bridge

Closing: DEVRL-1020

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

⚠️ No Changeset found

Latest commit: 74ba8df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit 74ba8df
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6499d24fcb029400081e7202
😎 Deploy Preview https://deploy-preview-6147--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@qbzzt qbzzt requested a review from tynes June 26, 2023 18:04
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #6147 (74ba8df) into develop (374301d) will increase coverage by 0.18%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6147      +/-   ##
===========================================
+ Coverage    45.71%   45.89%   +0.18%     
===========================================
  Files          439      325     -114     
  Lines        28239    24955    -3284     
  Branches       675        0     -675     
===========================================
- Hits         12910    11454    -1456     
+ Misses       14279    12497    -1782     
+ Partials      1050     1004      -46     
Flag Coverage Δ
bedrock-go-tests 44.96% <ø> (ø)
cannon-go-tests 61.71% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests ?
core-utils-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 114 files with indirect coverage changes

@qbzzt qbzzt merged commit 3eda4cd into develop Jun 26, 2023
10 checks passed
@qbzzt qbzzt deleted the qbzzt/230626-opstack-getting-started branch June 26, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants