Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in comment #6165

Merged
merged 3 commits into from
Jul 2, 2023

Conversation

pengin7384
Copy link
Contributor

Description

Fix typo in comment.

Tests

None

Additional context

None

Metadata

None

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2023

⚠️ No Changeset found

Latest commit: 8d2b2ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit 8d2b2ec
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64a1513db59ea9000800293f
😎 Deploy Preview https://deploy-preview-6165--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYVM

@trianglesphere
Copy link
Contributor

@pengin7384 please merge in develop to make CI pass

@pengin7384
Copy link
Contributor Author

@trianglesphere How can I activate mergify? The merge condition seems to be met.

@trianglesphere
Copy link
Contributor

@trianglesphere How can I activate mergify? The merge condition seems to be met.

merge conditions are not met. You need to merge in the latest version of develop to make CI pass.

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #6165 (8d2b2ec) into develop (8ddf2cd) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6165      +/-   ##
===========================================
+ Coverage    44.16%   44.21%   +0.04%     
===========================================
  Files          436      436              
  Lines        29025    29025              
  Branches       709      709              
===========================================
+ Hits         12818    12832      +14     
+ Misses       15126    15113      -13     
+ Partials      1081     1080       -1     
Flag Coverage Δ
bedrock-go-tests 43.09% <ø> (-0.01%) ⬇️
cannon-go-tests 61.78% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 56.16% <ø> (+1.65%) ⬆️
core-utils-tests 49.06% <ø> (ø)
fault-detector-tests 26.95% <ø> (ø)
sdk-next-tests 42.47% <ø> (ø)
sdk-tests 42.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/rollup/derive/channel_bank.go 70.21% <ø> (ø)
op-node/rollup/derive/channel_in_reader.go 0.00% <ø> (ø)
op-node/rollup/derive/engine_queue.go 44.89% <ø> (ø)
op-node/rollup/derive/l1_retrieval.go 84.37% <ø> (ø)
op-node/rollup/derive/l2block_util.go 55.88% <ø> (ø)
op-node/rollup/types.go 82.02% <ø> (ø)

... and 6 files with indirect coverage changes

@OptimismBot OptimismBot merged commit b7fd37e into ethereum-optimism:develop Jul 2, 2023
11 of 12 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 2, 2023
@pengin7384
Copy link
Contributor Author

Thank you! :)

seolaoh added a commit to kroma-network/kroma that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants