Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ctb): Semver lockfile #6455

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Conversation

clabby
Copy link
Member

@clabby clabby commented Jul 26, 2023

Overview

Adds a forge script that computes the source hash of all Semver-enabled contracts in contracts-bedrock and persists them. If the source hash changes and the semver lock hasn't been explicitly updated, CI will fail.

Metadata
Closes CLI-4281

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: d6698a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@clabby
Copy link
Member Author

clabby commented Jul 26, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the C-protocol-critical Category: Modifies protocol-critical code label Jul 26, 2023
@mergify mergify bot requested a review from smartcontracts July 26, 2023 15:20
@clabby clabby force-pushed the clabby/ctb/semver-assertions branch from 7587d09 to eb3869b Compare July 26, 2023 15:23
@clabby clabby marked this pull request as ready for review July 26, 2023 15:23
@clabby clabby requested review from a team as code owners July 26, 2023 15:23
@clabby clabby requested a review from felipe-op July 26, 2023 15:23
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sick and won't add CI scheduling issues because its in solidity with deps already installed

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #6455 (d6698a4) into develop (9af277e) will increase coverage by 0.08%.
Report is 4 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6455      +/-   ##
===========================================
+ Coverage    40.66%   40.74%   +0.08%     
===========================================
  Files          465      465              
  Lines        33461    33461              
  Branches      1949     1949              
===========================================
+ Hits         13606    13634      +28     
+ Misses       18376    18350      -26     
+ Partials      1479     1477       -2     
Flag Coverage Δ
bedrock-go-tests 43.93% <ø> (+0.11%) ⬆️
cannon-go-tests 62.40% <ø> (ø)
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 44.62% <ø> (ø)
contracts-ts-tests 6.88% <ø> (ø)
core-utils-tests 44.24% <ø> (ø)
sdk-next-tests 42.60% <ø> (ø)
sdk-tests 42.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, nice!

@twoshark twoshark self-requested a review July 26, 2023 15:44
@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit bb9e17f into develop Jul 26, 2023
66 of 69 checks passed
@OptimismBot OptimismBot deleted the clabby/ctb/semver-assertions branch July 26, 2023 16:18
@mergify mergify bot removed the on-merge-train label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-protocol-critical Category: Modifies protocol-critical code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants