-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ctb): Semver lockfile #6455
Conversation
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
7587d09
to
eb3869b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is sick and won't add CI scheduling issues because its in solidity with deps already installed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6455 +/- ##
===========================================
+ Coverage 40.66% 40.74% +0.08%
===========================================
Files 465 465
Lines 33461 33461
Branches 1949 1949
===========================================
+ Hits 13606 13634 +28
+ Misses 18376 18350 -26
+ Partials 1479 1477 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, nice!
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Overview
Adds a forge script that computes the source hash of all Semver-enabled contracts in
contracts-bedrock
and persists them. If the source hash changes and the semver lock hasn't been explicitly updated, CI will fail.Metadata
Closes CLI-4281