-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: add sepolia config #6461
Conversation
This should be double checked against the JSON file that was generated by the genesis command: ``` { "genesis": { "l1": { "hash": "0x4b29002c963e450d79b5acec0649654f9b806cc5b2fe3dfafac2e5379bea1653", "number": 3969582 }, "l2": { "hash": "0x96c6b5aa7836051bdef7527cc935a9837edfe16aba735259e54af407bb41dd84", "number": 0 }, "l2_time": 1690397376, "system_config": { "batcherAddr": "0x7431310e026b69bfc676c0013e12a1a11411eec9", "overhead": "0x00000000000000000000000000000000000000000000000000000000000000bc", "scalar": "0x00000000000000000000000000000000000000000000000000000000000a6fe0", "gasLimit": 30000000 } }, "block_time": 2, "max_sequencer_drift": 600, "seq_window_size": 3600, "channel_timeout": 300, "l1_chain_id": 11155111, "l2_chain_id": 11155420, "regolith_time": 0, "batch_inbox_address": "0xff00000000000000000000000000000011155420", "deposit_contract_address": "0xb31e909cb6f7e873891e146967759f0140f420a8", "l1_system_config_address": "0xc6a8e082fd9124e6175791086f448d61d95ca4a2" } ``` The values should be a combination of values used for goerli as well as values used on mainnet. The batcher addr is the goerli value, the scalar, overhead and gas limit are mainnet values. We need to double check that the genesis L1 block ref was not reorg'd out before committing to this. Regolith is activated at genesis, the batch inbox address follows the "correct" schema, the deposit and system config addresses should be referenced against the artifacts found in #6428 The chain id for sepolia should be checked and the L2 chain id is unused. The max seq drift, seq window size and channel timeout are all copied from goerli.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6461 +/- ##
===========================================
+ Coverage 40.85% 44.25% +3.40%
===========================================
Files 393 315 -78
Lines 32336 25108 -7228
Branches 1689 0 -1689
===========================================
- Hits 13211 11112 -2099
+ Misses 17684 12982 -4702
+ Partials 1441 1014 -427
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This should be double checked against the JSON file that was generated by the genesis command:
The values should be a combination of values used for goerli as well as values used on mainnet. The batcher addr is the goerli value, the scalar, overhead and gas limit are mainnet values.
We need to double check that the genesis L1 block ref was not reorg'd out before committing to this.
Regolith is activated at genesis, the batch inbox address follows the "correct" schema, the deposit and system config addresses should be referenced against the artifacts found in #6428
The chain id for sepolia should be checked and the L2 chain id is unused.
The max seq drift, seq window size and channel timeout are all copied from goerli.
Description
A clear and concise description of the features you're adding in this pull request.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata