Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: add sepolia config #6461

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jul 26, 2023

This should be double checked against the JSON file that was generated by the genesis command:

{
  "genesis": {
    "l1": {
      "hash": "0x70e5634d09793b1cfaa7d0a2a5d3289a3b2308de1e82f682b4f817fc670f9797",
      "number": 3976708
    },
    "l2": {
      "hash": "0xfbfc64b34d705b0eb83ab8b2206c0da90a76e1ae54ae657c8cfbee0e802a9120",
      "number": 0
    },
    "l2_time": 1690493568,
    "system_config": {
      "batcherAddr": "0x7431310e026b69bfc676c0013e12a1a11411eec9",
      "overhead": "0x00000000000000000000000000000000000000000000000000000000000000bc",
      "scalar": "0x00000000000000000000000000000000000000000000000000000000000a6fe0",
      "gasLimit": 30000000
    }
  },
  "block_time": 2,
  "max_sequencer_drift": 600,
  "seq_window_size": 3600,
  "channel_timeout": 300,
  "l1_chain_id": 11155111,
  "l2_chain_id": 11155420,
  "regolith_time": 0,
  "batch_inbox_address": "0xff00000000000000000000000000000011155420",
  "deposit_contract_address": "0x8f6452d842438c4e22ba18baa21652ff65530df4",
  "l1_system_config_address": "0xf425ed544d2e1f1b7a8650d5897a7ccf43020791"
}

The values should be a combination of values used for goerli as well as values used on mainnet. The batcher addr is the goerli value, the scalar, overhead and gas limit are mainnet values.

We need to double check that the genesis L1 block ref was not reorg'd out before committing to this.

Regolith is activated at genesis, the batch inbox address follows the "correct" schema, the deposit and system config addresses should be referenced against the artifacts found in #6428

The chain id for sepolia should be checked and the L2 chain id is unused.

The max seq drift, seq window size and channel timeout are all copied from goerli.

Description

A clear and concise description of the features you're adding in this pull request.

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

This should be double checked against the JSON file that was generated
by the genesis command:

```
{
  "genesis": {
    "l1": {
      "hash": "0x4b29002c963e450d79b5acec0649654f9b806cc5b2fe3dfafac2e5379bea1653",
      "number": 3969582
    },
    "l2": {
      "hash": "0x96c6b5aa7836051bdef7527cc935a9837edfe16aba735259e54af407bb41dd84",
      "number": 0
    },
    "l2_time": 1690397376,
    "system_config": {
      "batcherAddr": "0x7431310e026b69bfc676c0013e12a1a11411eec9",
      "overhead": "0x00000000000000000000000000000000000000000000000000000000000000bc",
      "scalar": "0x00000000000000000000000000000000000000000000000000000000000a6fe0",
      "gasLimit": 30000000
    }
  },
  "block_time": 2,
  "max_sequencer_drift": 600,
  "seq_window_size": 3600,
  "channel_timeout": 300,
  "l1_chain_id": 11155111,
  "l2_chain_id": 11155420,
  "regolith_time": 0,
  "batch_inbox_address": "0xff00000000000000000000000000000011155420",
  "deposit_contract_address": "0xb31e909cb6f7e873891e146967759f0140f420a8",
  "l1_system_config_address": "0xc6a8e082fd9124e6175791086f448d61d95ca4a2"
}
```

The values should be a combination of values used for goerli as well
as values used on mainnet. The batcher addr is the goerli value, the
scalar, overhead and gas limit are mainnet values.

We need to double check that the genesis L1 block ref was not reorg'd
out before committing to this.

Regolith is activated at genesis, the batch inbox address follows the
"correct" schema, the deposit and system config addresses should be
referenced against the artifacts found in #6428

The chain id for sepolia should be checked and the L2 chain id is
unused.

The max seq drift, seq window size and channel timeout are all
copied from goerli.
@tynes tynes requested a review from a team as a code owner July 26, 2023 18:58
@tynes tynes requested a review from mslipper July 26, 2023 18:58
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: 64a244e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #6461 (64a244e) into develop (a8b31e7) will increase coverage by 3.40%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6461      +/-   ##
===========================================
+ Coverage    40.85%   44.25%   +3.40%     
===========================================
  Files          393      315      -78     
  Lines        32336    25108    -7228     
  Branches      1689        0    -1689     
===========================================
- Hits         13211    11112    -2099     
+ Misses       17684    12982    -4702     
+ Partials      1441     1014     -427     
Flag Coverage Δ
bedrock-go-tests 44.25% <ø> (ø)
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
op-node/chaincfg/chains.go 100.00% <ø> (ø)

... and 78 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 28, 2023
@OptimismBot OptimismBot merged commit 5390cb4 into develop Jul 28, 2023
69 of 70 checks passed
@OptimismBot OptimismBot deleted the feat/sepolia-op-node-config branch July 28, 2023 16:27
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants