op-batcher: Make channel manager safe for concurrent use #6878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the batcher is concurrent with respect to sending transactions, the main loop would fetch transaction data & record transaction status updates in different go routines. This would lead to concurrent access of the txChannels map which causes a panic. This commit adds locks to the public methods for the channel manager to make it safe for concurrent use. Co-authored-by: bnoieh <135800952+bnoieh@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6878 +/- ##
===========================================
+ Coverage 44.82% 50.74% +5.92%
===========================================
Files 376 314 -62
Lines 29542 23677 -5865
Branches 1692 0 -1692
===========================================
- Hits 13242 12016 -1226
+ Misses 14858 10617 -4241
+ Partials 1442 1044 -398
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
tynes
approved these changes
Aug 18, 2023
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because the batcher is concurrent with respect to sending transactions, the main loop would fetch transaction data & record transaction status updates in different go routines. This would lead to concurrent access of the txChannels map which causes a panic.
This commit adds locks to the public methods for the channel manager to make it safe for concurrent use.
Reported by bnoeih in #6093
Tests
None.
Metadata