Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: un-hide beta flags, update superchain-registry for devnet protocol-versions monitoring #7337

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

protolambda
Copy link
Contributor

@protolambda protolambda commented Sep 21, 2023

Description

  • Un-hide the beta-flags, so the beta features are visible to more users
  • Update the superchain-registry, to incude the op-labs devnet
  • Fix runtime & L2 init order, so the L2 engine API client is created before it's used by the runtime config when signaling protocol version info
  • Load the protocol-versions address from the superchain-registry into the rollup-config.

Flags to join the devnet:

                  --network=op-labs-devnet-0-goerli-dev-0 \
                  --beta.extra-networks \
                  --beta.rollup.halt=minor \
                  --beta.rollup.load-protocol-versions

Or, if using a manual rollup.json, add the protocol_versions_address manually to the config file.

Tests

Tested live on devnet:


# setting recommended to v3.1.0-1
cast send --rpc-url=$ETH_RPC_URL --private-key=$PRIVATE_KEY 0x79ADD5713B383DAa0a138d3C4780C7A1804a8090 'setRecommended(uint256)' 0x0000000000000000000000000000000000000003000000010000000000000001
https://goerli.etherscan.io/tx/0x3ca0a70d33b5618b5a3f543df06f3c449af8f40f3b017e0ed703c78146e1e045

# setting required to v3.2.0, to test out-of-date signal on live devnet
cast send --rpc-url=$ETH_RPC_URL --private-key=$PRIVATE_KEY 0x79ADD5713B383DAa0a138d3C4780C7A1804a8090 'setRequired(uint256)' 0x0000000000000000000000000000000000000003000000020000000000000000
https://goerli.etherscan.io/tx/0xd0935c2a112ba979fb12d24e4a87bdecddc4584ffb10da7d5a862048cd7a6c91

# setting required back to v3.1.0-1
cast send --rpc-url=$ETH_RPC_URL --private-key=$PRIVATE_KEY 0x79ADD5713B383DAa0a138d3C4780C7A1804a8090 'setRequired(uint256)' 0x0000000000000000000000000000000000000003000000010000000000000001

@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2023

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added S-conflict Status: A conflict is present A-op-node Area: op-node labels Sep 21, 2023
@mergify mergify bot removed the S-conflict Status: A conflict is present label Sep 21, 2023
trianglesphere
trianglesphere previously approved these changes Sep 21, 2023
go.mod Outdated Show resolved Hide resolved
@protolambda
Copy link
Contributor Author

Found a config issue where the devnet wasn't configured with the same defaults as the other newer networks, causing a bad rollup config. Will fix that and then this PR can be reviewed again. This only affects the devnet config through the beta-flag though.

@protolambda protolambda removed the M-do-not-merge Meta: Do not merge label Sep 21, 2023
@OptimismBot OptimismBot merged commit 76b6589 into develop Sep 22, 2023
@OptimismBot OptimismBot deleted the devnet-protocol-versions branch September 22, 2023 18:31
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot added the S-on-merge-train Status: This PR is in the merge queue label Sep 22, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the S-on-merge-train Status: This PR is in the merge queue label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-node Area: op-node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants