Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-challenger: fixes latestBlockNumber signature and ROOT_CLAIM length #8136

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

joseandro
Copy link
Contributor

Description
Two issues were found while running the op-challenger && make alphabet command with foundry 0.2.0. Those issues prevent users from playing Alphabet's bisection game:

  1. The public view parameters in latestBlockNumber() found in op-challenger/scripts/create_game.sh were causing cast call to fail.
  2. The slicing of ROOT_CLAIM in op-challenger/scripts/alphabet/init_game.sh was yielding less than 32 bytes.

Tests
Executed the existing scripts in op-challenger && make alphabet successfully using foundry's toolset version 0.2.0.

@joseandro joseandro requested a review from a team as a code owner November 11, 2023 21:09
@joseandro joseandro requested a review from tynes November 11, 2023 21:09
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #8136 (cdece16) into develop (079a99b) will decrease coverage by 0.51%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #8136      +/-   ##
===========================================
- Coverage    53.83%   53.33%   -0.51%     
===========================================
  Files          162      162              
  Lines         6171     6171              
  Branches       966      966              
===========================================
- Hits          3322     3291      -31     
- Misses        2723     2756      +33     
+ Partials       126      124       -2     
Flag Coverage Δ
cannon-go-tests 63.47% <ø> (ø)
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests 26.74% <ø> (ø)
contracts-bedrock-tests 60.31% <ø> (-1.58%) ⬇️
contracts-ts-tests 100.00% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-next-tests 41.92% <ø> (ø)
sdk-tests 41.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating this.

@ajsutton ajsutton added this pull request to the merge queue Nov 12, 2023
Merged via the queue into ethereum-optimism:develop with commit 23ba757 Nov 13, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants