op-node: Fix race condition closing gossip handler.

[ajsutton]

Description

LogTopicEvents is calling Cancel on the event handler it logs from. This is done in a go routine but Cancel is not thread safe. Cancel is called from the blockTopic.Close function anyway so the log code can simply leave it to that.

Metadata

• Enabled golang race detector in CI/Tests #8488

[coderabbitai]

Warning

Rate Limit Exceeded

@ajsutton has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 13 minutes and 56 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between a298160 and 5769a8d.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[ajsutton]

@CodeRabbitSupport It's really annoying that the rabbit posts a comment to say it won't be useful and even more annoying that it tags you to say its not helpful. Similarly it just creates noise when it comments to say it is processing and will comment soon. It would be great if it could be configured to stay completely quiet until it has actual review feedback.

[codecov]

Codecov Report

Merging #8576 (5769a8d) into develop (a298160) will decrease coverage by 14.40%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #8576       +/-   ##
============================================
- Coverage    34.64%   20.24%   -14.40%     
============================================
  Files          167       88       -79     
  Lines         7155     2094     -5061     
  Branches      1209      478      -731     
============================================
- Hits          2479      424     -2055     
+ Misses        4525     1642     -2883     
+ Partials       151       28      -123     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	?
common-ts-tests	?
contracts-bedrock-tests	20.24% <ø> (-0.15%)	⬇️
contracts-ts-tests	?
core-utils-tests	?
sdk-next-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 82 files with indirect coverage changes

[sebastianst]

LGTM, confirmed it's closed elsewhere.