Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-service/txmgr: Bump fees by at least 1 wei #8713

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

sebastianst
Copy link
Member

Description

Fixes an edge-case during near-zero network fee conditions.

Tests

Added test that failed before change.

Additional context

The lack of this causes the txmgr to not properly bump very low fees. E.g. 2 wei + 10% is still 2 wei, rounded, so no bump would happen.

Copy link
Contributor

coderabbitai bot commented Dec 20, 2023

Walkthrough

Walkthrough

The recent update involves a modification to the transaction manager's threshold calculation logic, ensuring a minimum increment of 1 wei in scenarios where network fees are extremely low. Additionally, the test suite for the transaction manager has been expanded with a new test case to verify that the gas price increment logic functions correctly, particularly ensuring the transaction's fee cap and tip are appropriately increased.

Changes

File(s) Change Summary
op-service/txmgr/txmgr.go
op-service/txmgr/txmgr_test.go
Updated calcThresholdValue function to add 1 wei to the threshold if it equals the original x value, addressing near-zero fee conditions. Added a new test case "bump at least 1" to TestIncreaseGasPrice function, enhancing test coverage for gas price increase logic.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion that may be simpler but LGTM.

op-service/txmgr/txmgr.go Outdated Show resolved Hide resolved
Edge-case during near-zero network fee conditions.
@ajsutton ajsutton added this pull request to the merge queue Dec 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2023
@trianglesphere trianglesphere added this pull request to the merge queue Dec 21, 2023
Merged via the queue into develop with commit 4c70fc1 Dec 21, 2023
61 checks passed
@trianglesphere trianglesphere deleted the seb/txmgr-bump-1 branch December 21, 2023 00:43
roberto-bayardo pushed a commit to roberto-bayardo/optimism that referenced this pull request Dec 21, 2023
Edge-case during near-zero network fee conditions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants