[txmgr] Ensure that fee is increased by at least 10%

[mdehoog]

Description

#8713 fixed a txmgr bug where if the fees were < 10, the fee would not be bumped at all.

This PR ensures we conform to the spec a little more, guaranteeing that we bump the fee by at least 10%.

For example, the current implementation will bump 11 to 12, which is not technically 10% more (because we do floor(fee * 1.1). This PR switches to use ceil(fee * 1.1).

Tests

Updated tests.

Additional context

go-ethereum currently rounds down internally, so this would not affect L1s running geth.

[coderabbitai]

Walkthrough

Walkthrough

The update pertains to the transaction manager component, involving a refinement in the gas price calculation logic. A new constant has been introduced to fine-tune the threshold value used in the calculation. Additionally, the test suite has been adjusted to align with the updated logic, changing the expected outcomes for gas price limit scenarios.

Changes

File(s)	Change Summary
op-service/.../txmgr.go	Modified calcThresholdValue function to incorporate a new constant ninetyNine and updated the logic for adding 1 wei.
op-service/.../txmgr_test.go	Updated TestIncreaseGasPriceLimits to reflect new expected tip and fee caps following the changes in gas price limit calculations.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
• You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • @coderabbitai generate unit tests for this file
  • @coderabbitai modularize this function
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. Examples:
  • @coderabbitai render interesting statistics about this repository as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[sebastianst]

Thanks, that's indeed the proper way to do it!