This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Make rollup node spec consistent with deposit spec #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norswap
force-pushed
the
ns/consistent-rollup-spec
branch
from
66f3754
to
037749a
Compare
Merged
norswap
force-pushed
the
ns/consistent-rollup-spec
branch
from
037749a
to
1bf3116
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
This is the first part of a series of spec improvement PR. This one makes the rollup node and the deposit spec consistent.
The main change there was that we settled on the "L1 attributes transaction" to be an " L1 attributes deposit" sharing the same format as user-submitted deposits (now called "transaction deposits"). Most of the change in this PR reflect this change in the rollup node spec and in the glossary.
Subsequent PRs will:
(Note a few parasitic changes in the
deposits.mdfile because it was aligned to a 100 characters boundary except for a few paragraphs that I have realigned. Sorry about the noise!)