-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
79462b9
to
235ca32
Compare
specs/deposits.md
Outdated
The bytecode to add to the genesis file will be located in the | ||
`deployedBytecode` of the [JSON artifact file][l1-block-artifacts] corresponding | ||
to L1Block.sol (this link will be broken unless you've built the contracts with | ||
`yarn build` in the `packages/contracts` directory). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just remove this link and display the path textually instead. @maurelian wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I made a suggestion below that I think gets this across well.
I couldn't get it to check absolute links. Opened an issue @ lychee here: https://github.com/lycheeverse/lychee-action/issues/70 In the meantime, I've changed the absolute links from |
Following @trianglesphere's comment, I rechecked and found quite a few more broken link references (e.g. Lychee issue: lycheeverse/lychee#456 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good with these small changes
specs/deposits.md
Outdated
The bytecode to add to the genesis file will be located in the | ||
`deployedBytecode` of the [JSON artifact file][l1-block-artifacts] corresponding | ||
to L1Block.sol (this link will be broken unless you've built the contracts with | ||
`yarn build` in the `packages/contracts` directory). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I made a suggestion below that I think gets this across well.
0d36e7b
to
fc555be
Compare
|
Closes #115 and #116
Built on top on #117, don't merge!
Uses https://github.com/lycheeverse/lychee for link checking.
A bit unsure about the github workflow, needs testing.It works.I'm expecting the workflow to fail at first, because we have one link to a build output, so eitherwe must add contract building to the workflow, or add an exception.
It passes, but that itself is a problem, because it's caused by lychee not checking absolute (
/
-prefixed) links.