Enshrine standard vs frontier chains in yaml enum #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
commented
Mar 20, 2024
5 tasks
geoknee
commented
Mar 20, 2024
and update scripts and instructions accordingly
geoknee
force-pushed
the
gk/frontier-flag
branch
from
61ae41d
to
2bc1df6
Compare
…ains Retain existing OPChains (contains the union of Standardchains and FrontierChains)
geoknee
commented
Mar 21, 2024
blmalone
reviewed
Mar 21, 2024
mds1
reviewed
Mar 25, 2024
mds1
reviewed
Mar 25, 2024
mds1
reviewed
Mar 25, 2024
- add show_usage() fn - use SUPERCHAIN_LEVEL var
geoknee
changed the title
mds1
approved these changes
Apr 1, 2024
axelKingsley
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
I have reviewed the Go and Yaml changes only, as a go-reviewer.
Looks like we've added a single enum field, and set the chains as
Zora-main: Frontier
PGN-main: Frontier
Orderly-main: Frontier
OP-main: Standard
Mode-main: Standard
Lyra-main: Frontier
Base-main: Standard
Zora-sepolia: Standard
PGN-sepolia: Frontier
OP-sepolia: Standard
Base-sepolia: Standard
OP-dev: Standard
Base-dev: Standard
That makes sense to me!
geoknee
commented
Apr 1, 2024
This was referenced Apr 1, 2024
mds1
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethereum-optimism/security-pod/issues/82
I considered and discarded the alternative approach of having an even more deeply nested folder structure here #137.
This is a pretty lightweight way of demarcating the two types of chains, which: