Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-155: design problem in unique chain IDs #1747

Closed
lukaszmatczak opened this issue Feb 11, 2019 · 2 comments
Closed

EIP-155: design problem in unique chain IDs #1747

lukaszmatczak opened this issue Feb 11, 2019 · 2 comments

Comments

@lukaszmatczak
Copy link

EIP-155 requires that different chains must have unique chain ID. Specification contains list of chains with their IDs, but it turns out that this list is incomplete and contains only biggest chains. There's no official full list (I think we can't assume that https://github.com/ethereum-lists/chains is official list because it's not mentioned in EIP-155).

Requiring unique ID without providing list of used IDs looks like serious design problem in EIP-155. There's no way to check if given chain ID is free. As a result, there may appear conflicts like ethereum-lists/chains#25

To resolve this issue I propose to include full list in EIP-155 or create an official list somewhere and insert link to it in specification.

@ligi
Copy link
Member

ligi commented Feb 11, 2019

I think we can't assume that https://github.com/ethereum-lists/chains is official list because it's not mentioned in EIP-155)

I opened a PR about a month ago to add it: #1703

Not to make it official (I think in a decentralized word this word is very problematic) - but to avoid collisions by making people aware of existing chain ids.

There was no signal yet against it - but it did not get merged yet. The problem is EIP155 is done by @vbuterin - so he need to approve to trigger the merge - but I think he has more important things to do.

Adding all chains via PRs to ethereum/EIPs sounds like a big overhead and will make EIP numbers even larger. Especially with so many chains popping up over time.

@nicksavers
Copy link
Contributor

Hopefully resolved through #1703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants