-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename review-period-end
to last-call-end
or last-call-deadline
#4413
Comments
review-period-end
to last-call-end
review-period-end
to last-call-end
or last-call-deadline
@alita-moore I know there's an issue about the bot pestering incorrectly, but now it also shows the |
Weird, okay. I'll append that to the ticket. Btw issues are more likely to be solved if you mention them in the eth-bot repo. Just because it's easier for me to organize |
We discussed this on the EIPIP call, everyone is OK with this change, and either |
Started doing this, depends on ethereum/eipv#35 now. |
It is confusing when the
Review
state doesn't require it, but theLast Call
state does. It should have been changed when theReview
state (at last) was introduced.The text was updated successfully, but these errors were encountered: