Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename review-period-end to last-call-end or last-call-deadline #4413

Closed
axic opened this issue Nov 2, 2021 · 5 comments · Fixed by #4438
Closed

Rename review-period-end to last-call-end or last-call-deadline #4413

axic opened this issue Nov 2, 2021 · 5 comments · Fixed by #4438

Comments

@axic
Copy link
Member

axic commented Nov 2, 2021

It is confusing when the Review state doesn't require it, but the Last Call state does. It should have been changed when the Review state (at last) was introduced.

@axic
Copy link
Member Author

axic commented Nov 2, 2021

cc @MicahZoltu @lightclient

@axic axic changed the title Rename review-period-end to last-call-end Rename review-period-end to last-call-end or last-call-deadline Nov 2, 2021
@axic
Copy link
Member Author

axic commented Nov 2, 2021

@alita-moore I know there's an issue about the bot pestering incorrectly, but now it also shows the \n\n newline characters are not properly handled.

@alita-moore
Copy link
Contributor

Weird, okay. I'll append that to the ticket. Btw issues are more likely to be solved if you mention them in the eth-bot repo. Just because it's easier for me to organize

@MicahZoltu
Copy link
Contributor

MicahZoltu commented Nov 4, 2021

We discussed this on the EIPIP call, everyone is OK with this change, and either last-call-end or last-call-deadline are acceptable. Whoever opens a PR to make this change gets to pick teh name to use. 😀

@axic
Copy link
Member Author

axic commented Nov 5, 2021

Started doing this, depends on ethereum/eipv#35 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants