Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode for eips webfront #7549

Closed
g11tech opened this issue Aug 31, 2023 · 12 comments · Fixed by #7664
Closed

Dark mode for eips webfront #7549

g11tech opened this issue Aug 31, 2023 · 12 comments · Fixed by #7664

Comments

@g11tech
Copy link
Contributor

g11tech commented Aug 31, 2023

Proposed Change

Add dark mode and enable switching between dark mode and normal mode on https://eips.ethereum.org/

@Pandapip1
Copy link
Member

+0. Would require JS.

@xinbenlv
Copy link
Contributor

Could be added to EIP.info

@SamWilsn
Copy link
Contributor

SamWilsn commented Sep 1, 2023

+0. Would require JS.

A toggle button would, yes. I am also neutral about that.

I think we could at least support browser's native colour scheme with: prefers-color-scheme?

@g11tech
Copy link
Contributor Author

g11tech commented Sep 1, 2023

I think we could at least support browser's native colour scheme with: prefers-color-scheme?

should work

@Pandapip1
Copy link
Member

Pandapip1 commented Sep 1, 2023

Could be added to EIP.info

Already is :)

image

@Pandapip1
Copy link
Member

I think we could at least support browser's native colour scheme with: prefers-color-scheme?

+1 to supporting that.

@SamWilsn
Copy link
Contributor

SamWilsn commented Sep 1, 2023

I thought this would be as simple as adding the media-query and upgrading to bootstrap 5.3 (where they add colour scheme support), but it seems like there's some CSS compilation magic going on that makes it more difficult...

@Pandapip1
Copy link
Member

Pandapip1 commented Sep 1, 2023

There is some CSS compilation magic done by Jekyll and its theme, yes.

Yet another reason to switch to vitepress, which is out of beta ;)

@g11tech
Copy link
Contributor Author

g11tech commented Sep 2, 2023

is there a reason we not using react etc? i can help with react and may be make eips more interactive - have few ideas

@SamWilsn
Copy link
Contributor

SamWilsn commented Sep 3, 2023

is there a reason we not using react etc?

@lightclient and I are firmly against any complex frontend JavaScript.


Speaking only for myself:

The EIPs website should be 80-90% functional with JavaScript completely disabled or when viewed in lynx or links.

Provided the rest of the site is still usable without JS, I'd be okay with, for example, a light/dark toggle, tooltips when hovering over links to EIPS, or a client-side search.

@Pandapip1
Copy link
Member

is there a reason we not using react etc? i can help with react and may be make eips more interactive - have few ideas

I've made https://eip.info/ (https://github.com/3webs-org/eip-info-website), is something like that what you're looking for?

@g11tech
Copy link
Contributor Author

g11tech commented Sep 6, 2023

is there a reason we not using react etc? i can help with react and may be make eips more interactive - have few ideas

I've made https://eip.info/ (https://github.com/3webs-org/eip-info-website), is something like that what you're looking for?

actually this looks amazing! ❤️

SamWilsn added a commit to SamWilsn/EIPs that referenced this issue Sep 6, 2023
eth-bot pushed a commit that referenced this issue Sep 6, 2023
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this issue Oct 27, 2023
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this issue Jan 30, 2024
just-a-node pushed a commit to connext/EIPs that referenced this issue Feb 17, 2024
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this issue Jun 19, 2024
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this issue Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants