Fix JSON syntax #1578
Merged
Fix JSON syntax #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the previous JSON may be valid for some interpreters (like JavaScript's) it's not valid according to RFC 4627 due to the trailing commas.
fulldecent
approved these changes
Nov 27, 2018
|
Looks good, thanks for your help |
|
@Arachnid Can this be merged? |
Arachnid
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the previous JSON may be valid for some interpreters (like JavaScript's) it's not valid according to RFC 4627 due to the trailing commas [1].
[1] "An object structure is represented [...]. A single comma separates a value from a following name."