Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring over current copy of IfDefElse spec. #1804

Merged
merged 4 commits into from
Mar 2, 2019

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Mar 1, 2019

Bring over https://github.com/ifdefelse/ProgPOW/blob/master/README.md
with only changes needed for EIP formatting (header, test vector file name,
license and copyright, main sections)

Bring over https://github.com/ifdefelse/ProgPOW/blob/master/README.md
with only changes needed for EIP formatting (header, test vector file name,
license and copyright, main sections)
@@ -0,0 +1,457 @@
# Test Vectors for EIP-1057 - ProgPow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should go into assets/eip-1057/<chose a filename>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ifdefelse
Copy link
Contributor

We sign off on this update. It brings EIP up-to-date with our repo's Readme.

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • File assets/eip-1057/test-vectors.md is not an EIP
  • EIP 1057 requires approval from one of (@ifdefelse)

@nicksavers
Copy link
Contributor

nicksavers commented Mar 2, 2019

@ifdefelse I noticed that 'Ethash' is used inconsistently thoughout the document capitalized and uncapitalized. Is there any particular reason for that?

Note: For future reference, the @eip-automerger bot reacts to an Approval on the "File changes > Review changes"-button

@nicksavers nicksavers merged commit 55ff244 into ethereum:master Mar 2, 2019
@shemnon shemnon deleted the EIP-1057 branch March 3, 2019 03:24
corollari pushed a commit to corollari/EIPs that referenced this pull request Mar 4, 2019
@salanki
Copy link

salanki commented Mar 4, 2019

Seems as this didn't include the 0.9.3 changes @shemnon.

ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants