Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first draft of blind auctions EIP #1815

Open
wants to merge 12 commits into
base: master
from

Conversation

@corollari
Copy link
Contributor

corollari commented Mar 4, 2019

First draft of an EIP that standardises the interface of blind auction contracts.

Discussion: #1745

@corollari corollari force-pushed the corollari:blind-auction2 branch from 4970c94 to 744dec5 Mar 4, 2019
@axic

This comment has been minimized.

Copy link
Member

axic commented May 19, 2019

@corollari can you please rebase this on master so it can be merged (some new checks were introduced)?

@corollari

This comment has been minimized.

Copy link
Contributor Author

corollari commented May 19, 2019

sure!

@corollari corollari force-pushed the corollari:blind-auction2 branch from 744dec5 to 90a8d59 May 19, 2019

## Motivation
<!--The motivation is critical for EIPs that want to change the Ethereum protocol. It should clearly explain why the existing protocol specification is inadequate to address the problem that the EIP solves. EIP submissions without sufficient motivation may be rejected outright.-->
Many dApps that use blind auctions have appeared in the last years, each one reinventing the wheel and implementing blind auctions in ways that are conceptually similar but with special quirks and different interfaces, thus making it impossible for a system to interact with all of these without accommodating all these differences. This ERC aims to solve that by standarizing an interface for blind auctions contracts, which will enable the creation of systems that can interact with any blind auctions without requiring specialized code.

This comment has been minimized.

Copy link
@axic

axic May 20, 2019

Member

Can you add some examples for these "many dapps" (including links to the interfaces they use)?

This can be placed in a section called References or perhaps in Rationale explaining some of the decisions based on those.

This comment has been minimized.

Copy link
@corollari

corollari May 20, 2019

Author Contributor

Sure, in an earlier version I used to have a list of other projects using blind auctions but I ended up deleting it because it felt like just having a list didn't really add much value. I'll just restore it

This comment has been minimized.

Copy link
@axic

axic May 20, 2019

Member

It can be a good way to show the user base and that may help in engaging with those projects.

This comment has been minimized.

Copy link
@corollari

corollari May 20, 2019

Author Contributor

Added a list of some projects that implemented blind auctions (all of them with slight differences). Not sure how many I should list so just left it at 5.

EIPS/eip-1815.md Outdated Show resolved Hide resolved
@corollari corollari force-pushed the corollari:blind-auction2 branch from fee6ab9 to 51f21bc May 20, 2019
interface BlindAuction {
enum Mode { Open, Auction, Owned, Forbidden, Reveal, NotYetAvailable }
event AuctionStarted(bytes32 indexed hash, uint registrationDate);

This comment has been minimized.

Copy link
@axic

axic May 20, 2019

Member

I think it would be a good idea to comment (perhaps using NatSpec) each of these interfaces as done in other ERCs. See http://eips.ethereum.org/EIPS/eip-721 as an example.

This comment has been minimized.

Copy link
@corollari

corollari May 20, 2019

Author Contributor

Will start working on it

EIPS/eip-1815.md Outdated Show resolved Hide resolved

## Rationale
<!--The rationale fleshes out the specification by describing what motivated the design and why particular design decisions were made. It should describe alternate designs that were considered and related work, e.g. how the feature is supported in other languages. The rationale may also provide evidence of consensus within the community, and should discuss important objections or concerns raised during discussion.-->
The interface proposed has been chosen because it is the one used by the Ethereum Name System, which is the most popular project among the ones that use blind auctions, therefore being the one that has the most systems that integrate with it. By picking this interface we aim at minimizing the total amount of work that will be needed to migrate existing systems to the interface proposed, while maximizing the number of systems that will already be compatible with a contract implementing the interface described.

This comment has been minimized.

Copy link
@axic

axic May 20, 2019

Member

If this is an exact copy of what ENS is using, maybe it would be courteous to include the ENS authors in the author field of the ERC?

This comment has been minimized.

Copy link
@corollari

corollari May 20, 2019

Author Contributor

I've previously contacted some of them and they didn't seem interested in being authors but I'll try to contact the others.
Edit: If someone else (from the ENS or not) is interested in authoring this EIP along with me please reach out!

@axic axic added the type: ERC label May 20, 2019
@corollari

This comment has been minimized.

Copy link
Contributor Author

corollari commented May 20, 2019

Thanks for the feedback.

EIPS/eip-1815.md Outdated Show resolved Hide resolved
corollari added 7 commits May 20, 2019
@corollari

This comment has been minimized.

Copy link
Contributor Author

corollari commented May 20, 2019

Added another implementation by me that is currently WIP.

EIPS/eip-1815.md Show resolved Hide resolved
EIPS/eip-1815.md Show resolved Hide resolved
@axic axic dismissed their stale review May 22, 2019

Still wip.

@corollari

This comment has been minimized.

Copy link
Contributor Author

corollari commented May 29, 2019

I won't be able to work on this PR for the upcoming month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.