Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-152: Blake2b F precompile #2129

Merged
merged 39 commits into from
Aug 22, 2019
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
89a8794
Brought issue #152 into the repo as a draft EIP.
mhluongo Jun 16, 2019
843d377
Make the draft EIP consistent with the template
mhluongo Jun 16, 2019
3bcce1d
Break backwards compatibility into its own section
mhluongo Jun 16, 2019
c3f4c68
Added notes about the in-progress implementation
mhluongo Jun 16, 2019
92916e1
Specify EIP-2046 as a requirement
mhluongo Jun 16, 2019
764ff73
Don't use ABI encoding for precompile
mhluongo Jun 20, 2019
15c3352
Add @pdyraga to the EIP authors.
mhluongo Jun 20, 2019
552e602
Remove less relevant EIP rationale
mhluongo Jun 20, 2019
5a29338
Use 0x09 as the precompile address
mhluongo Jun 20, 2019
5d203c4
Choosing an EIP number
mhluongo Jun 21, 2019
6e7c49a
Add a missing colon
mhluongo Jun 24, 2019
ed06f26
Spelling updates
MadeofTin Jun 24, 2019
f6dadde
Add @MadeOfTin to the authors list
mhluongo Jun 24, 2019
eb54861
Prefer the original issue for discussion
mhluongo Jun 24, 2019
47ac208
Clarify the precompile's initial implementation
mhluongo Jun 25, 2019
29423a1
Make the precompile return value clear
mhluongo Jun 25, 2019
2f9384f
Clean up references wording
mhluongo Jun 25, 2019
7621447
More rationale around this BLAKE2b approach
mhluongo Jun 25, 2019
94ebe0c
Fix a couple misspellings
mhluongo Jun 26, 2019
787c2a0
Updated the interface for F precompile
pdyraga Jun 27, 2019
9c09e88
Updated gas cost section proposing GFROUND=1
pdyraga Jun 27, 2019
9d354f3
Detailed benchmarks moved to appendix section
pdyraga Jun 28, 2019
7cd9f95
Benchmark stats are compared against ecRecover as a baseline
pdyraga Jun 28, 2019
7338048
Clarification: f parameter is true if it is nonzero
pdyraga Jun 28, 2019
534e4b3
Avoid referring to abi.encodePacked
pdyraga Jul 4, 2019
ea28226
Fixed incorrect link
pdyraga Jul 4, 2019
2e33d58
Shortened the description about when parameter f is considered as true
pdyraga Jul 4, 2019
701280c
Minor grammar improvement
pdyraga Jul 4, 2019
64830d1
Updated information about endianness of F precompile inputs
pdyraga Aug 13, 2019
dcf86f6
Strict validation of f parameter
pdyraga Aug 13, 2019
e30104c
Initial test vectors for F precompile
pdyraga Aug 13, 2019
65f1caa
Test vector for a non-final round
pdyraga Aug 13, 2019
a40bc66
Test vector for the maximum number of rounds
pdyraga Aug 13, 2019
b8d33ba
Test vector for a single round
pdyraga Aug 13, 2019
7e2f8a1
Added test vector for empty input
pdyraga Aug 16, 2019
817e12d
The final block indicator (8-bit word) does not have endianness
pdyraga Aug 16, 2019
2386c0e
Clarify state vector encoding does not change in the output
pdyraga Aug 16, 2019
1255c52
Put too short input test vector next to empty input test vector
pdyraga Aug 16, 2019
272c45f
Added test vector for zero-rounds BLAKE2b case
pdyraga Aug 20, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading