GeoENS pull request - initial revision #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-choncholas
added a commit
to james-choncholas/geoens-dev
that referenced
this pull request
Dec 3, 2019
james-choncholas
added a commit
to james-choncholas/resolvers
that referenced
this pull request
May 8, 2020
GeoENS brings geographic split horizon capabilities to ENS. See more at EIP 2390 ethereum/EIPs#2390
james-choncholas
added a commit
to james-choncholas/resolvers
that referenced
this pull request
May 8, 2020
GeoENS brings geographic split horizon capabilities to ENS. See more at EIP 2390 ethereum/EIPs#2390
james-choncholas
added a commit
to james-choncholas/resolvers
that referenced
this pull request
May 8, 2020
GeoENS brings geographic split horizon capabilities to ENS. See more at EIP 2390 ethereum/EIPs#2390
james-choncholas
added a commit
to james-choncholas/resolvers
that referenced
this pull request
May 8, 2020
GeoENS brings geographic split horizon capabilities to ENS. See more at EIP 2390 ethereum/EIPs#2390
|
There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
MicahZoltu
suggested changes
Sep 9, 2020
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Flatten references and point discussion to new GitHub Issue
|
Thank you for your feedback! I appreciate your interest in this idea and have incorporated all your suggestions |
MicahZoltu
suggested changes
Sep 10, 2020
Co-authored-by: Micah Zoltu <micah@zoltu.net>
axic
reviewed
Sep 11, 2020
axic
reviewed
Sep 11, 2020
axic
reviewed
Sep 11, 2020
axic
reviewed
Sep 11, 2020
Add security considerations
Improve formatting and add note about different types of geohash
MicahZoltu
suggested changes
Sep 12, 2020
Co-authored-by: Micah Zoltu <micah@zoltu.net>
MicahZoltu
reviewed
Sep 13, 2020
Comment on lines
+313
to
+314
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
For repository wide consistency.
MicahZoltu
approved these changes
Sep 13, 2020
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
GeoENS brings geographic split horizon capabilities to ENS. It's GeoDNS for ENS!
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
GeoENS brings geographic split horizon capabilities to ENS. It's GeoDNS for ENS!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: