Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate file #2452

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Remove duplicate file #2452

merged 1 commit into from
Sep 11, 2020

Conversation

fulldecent
Copy link
Contributor

@fulldecent fulldecent commented Jan 3, 2020

This is a duplicate of https://eips.ethereum.org/EIPS/eip-1046

Ping for approval: Tommy Nicholas (@tomasienrbc), Matt Russo (@mateosu), John Zettler (@JohnZettler), Matt Condon (@shrugs)

See #1046 and #1047.

@fulldecent
Copy link
Contributor Author

@Arachnid approved above, requesting review please

@axic
Copy link
Member

axic commented Aug 28, 2020

While these two files were identical at the time they were merged, now they have diverged a tiny bit. To me it seems that EIP-1046 is the more "maintained" version, and would agree with removing it.

However, this opens the question and precedent: should "invalid" or mistakenly merged EIPs be ever removed or only marked Abandoned/Withdrawn/Superseded?

More feedback from @Souptacular @MicahZoltu @lightclient would be welcome.

@lightclient
Copy link
Member

lightclient commented Aug 28, 2020

I like the idea of editors having some "editorial power" in matters like this. I would generally agree that once an EIP is published, it should become a permanent fixture. But I also understand that the editors are trying to curate and publish a cohesive set of EIPs, and IMO deleting a duplicate (mistake) EIP is within the bounds of an editor's power.

Given that this EIP is still a draft, and based on it's limited reach (based on a brief few internet searches just now), I don't see an issue with merging this.

@MicahZoltu
Copy link
Contributor

I'm a fan of deleting abandoned EIPs rather than just flagging them as abandoned, but I believe I'm alone with this stance. In this case, I favor deletion but would accept abandoned.

@axic
Copy link
Member

axic commented Sep 10, 2020

Hah, I just noticed these are using reddit as a discussion url, see #2967.

@axic
Copy link
Member

axic commented Sep 10, 2020

@MicahZoltu @lightclient only realised now that the authors actually approved this. If they have I'm on board getting rid of it! It would be a different conversation should the authors not respond.

@MicahZoltu
Copy link
Contributor

With the author's approval, I'm good on deleting this if other editors are (which it sounds like they are).

@MicahZoltu MicahZoltu merged commit 6ce0652 into ethereum:master Sep 11, 2020
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants