move eip-712 to Last Call

[wschwab]

No description provided.

[eth-bot]

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

---

(fail) eip-712.md

classification
statusChange

• eip-712 state was changed from review to last call
• This PR requires review from one of [@lightclient, @axic, @SamWilsn, @Pandapip1]
• eip-712.md requires approval from one of (@recmo, @LogvinovLeon, @dekz)

[MicahZoltu]

I only review Core EIPs, so just a few comments here to help facilitate moving this along:

1. Simple Summary section has been removed.
2. A new description header field has been added that should contain a human readable one-line description of the EIP.
3. Remove external links. Inline things as appropriate or just remove the reference entirely.
4. Remove the Implementation section. This isn't a valid EIP section (also, the content in it isn't appropriate for an EIP).
5. Add missing Security Considerations section above Copyright section.
6. Rationale for domainSeparator needs an extra # leading it.

[wschwab]

Thanks @MicahZoltu ! I forgot to check back for comments until now, I'll get to work on these when I can.

[wschwab]

I'm working with Recmo to try and accommodate Micah's suggestions. Most are simple fixes, others are more complicated, particularly the external links one, which would require a significant amount of editing, and really even changing the way the EIP looks today. (Unless there's something I'm misunderstanding, which is totally possible.)

[wschwab]

(The most recent push should implement everything other than the external links, let me know if I missed something. Still working on finding a good solution on the links.)

[lightclient]

Could we also point the link to the JSON-RPC spec to https://github.com/ethereum/execution-apis?

Looks good to me otherwise.

[wschwab]

Could we also point the link to the JSON-RPC spec to https://github.com/ethereum/execution-apis?

Done

[lightclient]

LGTM - @recmo could you approve to move this forward? Thanks.

[lightclient]

@recmo bump

[wschwab]

I've incorporated the changes recommended in #4709 and also bumped the proposed Last Call date

plz review @recmo

[SamWilsn]

Not really stale, but waiting on authors (@recmo, @LogvinovLeon, @dekz).

[SamWilsn]

Also, if you're interested @wschwab, you should add yourself as an author.

[laurenceday]

Given the length of time that this EIP has taken - and the lack of response from @recmo - with it languishing for years now, the fact that we can't move the status forward without an author approving, and that this is becoming something of a bureaucratic blocker for other EIPs, might I propose that this is effectively 'forked' into a new EIP with authors more amenable to ticking the boxes required so that it can be finalised at last?

@wschwab can't add himself as an author to this EIP without a PR (whether or not he feels like he deserves this due to the nature of his contribution is somewhat by-the-by): that in and of itself requires the approval of an author.

[wschwab]

this is the simplest way for me to bump the date up, sorry for the clutter

[wschwab]

okay, I thought it was the simplest way to bump the last call date, but it seems to have gone completely off the rails, I'm trying to fix it up

[wschwab]

okay, now I'm actually really confused - it looks like someone got 712 to Last Call, trying to figure out when and how it happened