Make the stale bot ignore discussion urls #4436
Conversation
|
EIP file name must be eip-###.md |
.github/workflows/stale.yml
Outdated
| @@ -27,8 +27,7 @@ jobs: | |||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | |||
| days-before-stale: 180 | |||
| days-before-close: 14 | |||
| stale-pr-label: 'stale' | |||
| exempt-issue-labels: 'discussion-url' | |||
There was a problem hiding this comment.
Any better suggestion for the label?
There was a problem hiding this comment.
discussions-to maybe (so it matches the header field name in the EIP)?
There was a problem hiding this comment.
I'm fine with that, though the value is an uri. Perhaps we should rename it to discussion-uri both label and in the EIPs? :)
There was a problem hiding this comment.
I would approve a PR that changes it to discussion-uri everywhere. If you are going to immediately follow this PR up with all of the necessary PRs to change to discussion-uri I'm fine with leaving this as is. If that is just an idea to put on the backburner, I think we should maintain consistency for now and have the label match the field.
There was a problem hiding this comment.
Let me know which way you would like to go, or if you would like to continue discussion, so I can know to merge or not.
There was a problem hiding this comment.
Renamed to discussions-to here just to get this merged. We can make a bigger PR later and renaming the label is once off on Github, all tagged issues carry it over.
.github/workflows/stale.yml
Outdated
| @@ -27,8 +27,7 @@ jobs: | |||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | |||
| days-before-stale: 180 | |||
| days-before-close: 14 | |||
| stale-pr-label: 'stale' | |||
| exempt-issue-labels: 'discussion-url' | |||
There was a problem hiding this comment.
discussions-to maybe (so it matches the header field name in the EIP)?
| @@ -27,8 +27,7 @@ jobs: | |||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | |||
| days-before-stale: 180 | |||
| days-before-close: 14 | |||
| stale-pr-label: 'stale' | |||
There was a problem hiding this comment.
Why is this removed as well? Feels unrelated to the addition of exempt-issue-labels?
There was a problem hiding this comment.
We have two different configurations here: one for issues the other for PRs.
This section here is for the issue, and has the appropriate stale-issue-label. The stale-pr-label is a useless setting in this context.
* Make the stale bot ignore discussion urls * Fixes/cleanups * Update stale.yml
See https://github.com/actions/stale#exempt-issue-labels
After this change, if an issue is labeled
discussion-url, it will be exempt from closure. We should reopen the actual discussion URLs which have been closed recently and label them too.