ERC-4799 Non-Fungible Token Ownership Designation Standard #4800

davidbuckman · 2022-02-14T12:03:15Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

eth-bot · 2022-02-14T12:04:00Z

All tests passed; auto-merging...

(pass) eip-4799.md

classification
`updateEIP`

passed!

EIPS/eip-4800.md

SamWilsn · 2022-02-28T20:10:56Z

EIPS/eip-4799.md

+The following defines a standard interface for NFT wrapping contracts - contracts with which users can escrow their NFTs and receive a new provably authentic wrapped NFT that represents their ownership. This allows for the introduction of additional functionality for any preexisting NFT, without sacrificing authenticity.
+
+The standard works by exposing an interface that allows client applications to track a chain of authenticity from the original NFT contract to the final owner. The owner can transfer their NFT to an ERCX contract, which then assigns ownership according to its own code - say, back to the original owner. Then, applications that want to know who the owner of an NFT is will ask the original contract, and upon being told that the owner is an ERCX contract, will ask that ERCX contract who the owner of that token is - in our example, still the original owner. In this way, the original owner will still receive all the utility associated with their NFT, there is still only one owner for a given NFT, but the owner can now enjoy any added functionality provided by the implementation of the ERCX contract (say, the ability to rent ownership of their NFT).
+
+The standard works by exposing an interface that allows client applications to track a chain of authenticity from the original NFT contract to the final owner. Here is an example of a simple rental contract. The owner, Owner A can transfer their NFT to an ERCX contract, which then assigns ownership according to its own code - say, back to the Owner B. Then, applications that want to know who the owner of an NFT is will ask the original contract, and upon being told that the owner is an ERCX contract, will ask that ERCX contract who the owner of that token is - in our example, still the original owner. In this way, the original owner will still receive all the utility associated with their NFT, there is still only one owner for a given NFT, but the owner can now enjoy any added functionality provided by the implementation of the ERCX contract (say, the ability to rent ownership of their NFT).


I'd try to collapse this down a bit. The abstract should be a terse technical summary describing what the EIP specifies.

Cut this down to a single paragraph

SamWilsn · 2022-02-28T20:12:17Z

EIPS/eip-4799.md

+The key words “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY”, and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.
+
+```solidity
+// SPDX-License-Identifier: UNLICENSED


Should likely be CC0-1.0 to match the surrounding document.

SamWilsn · 2022-02-28T20:14:48Z

EIPS/eip-4799.md

+
+import "@openzeppelin/contracts/utils/introspection/IERC165.sol";
+
+interface IERCXNFT is IERC165 {


Might be worth re-ordering these interfaces so that they are read in the order they are required?

Had put the other one first since it's the core proposal, but re-ordered to be read in the order they are required

SamWilsn · 2022-02-28T20:18:30Z

EIPS/eip-4799.md

+
+## Rationale
+
+####


What's this?

SamWilsn

Some really small nits left. Unfortunately I can't just apply them for you since I'm not a maintainer on this repo 😅

I think this'll be good to merge after!

SamWilsn · 2022-03-25T22:11:24Z

EIPS/eip-4799.md

+
+## Security Considerations
+
+##### Long/Cyclical Chains of Ownership


Suggested change

##### Long/Cyclical Chains of Ownership

### Long/Cyclical Chains of Ownership

SamWilsn · 2022-03-25T22:11:38Z

EIPS/eip-4799.md

+
+## Backwards Compatibility
+
+The `IERC4799NFT` interface is backwards compatible with `IERC721`, as `IERC721` implicitly extends `IERC4799NFT`. This means that the ERC-4799 standard, which wraps NFTs that implement `ERC4799NFT`, is fully backwards compatible with ERC721.


Suggested change

The `IERC4799NFT` interface is backwards compatible with `IERC721`, as `IERC721` implicitly extends `IERC4799NFT`. This means that the ERC-4799 standard, which wraps NFTs that implement `ERC4799NFT`, is fully backwards compatible with ERC721.

The `IERC4799NFT` interface is backwards compatible with `IERC721`, as `IERC721` implicitly extends `IERC4799NFT`. This means that the ERC-4799 standard, which wraps NFTs that implement `ERC4799NFT`, is fully backwards compatible with ERC-721.

SamWilsn · 2022-03-25T22:12:15Z

EIPS/eip-4799.md

+
+## Rationale
+
+To maximize the future compatibility of the wrapping contract, we first defined a canonical NFT interface. We created `IERC4799NFT`, an interface implicitly implemented by virtually all popular NFT contracts, including all deployed contracts that are ERC-721 compliant. This interface represents the essence of an NFT: a mapping from a token identifier to the address of a singular owner, represented by the function `ownerOf`.


Suggested change

To maximize the future compatibility of the wrapping contract, we first defined a canonical NFT interface. We created `IERC4799NFT`, an interface implicitly implemented by virtually all popular NFT contracts, including all deployed contracts that are ERC-721 compliant. This interface represents the essence of an NFT: a mapping from a token identifier to the address of a singular owner, represented by the function `ownerOf`.

To maximize the future compatibility of the wrapping contract, we first defined a canonical NFT interface. We created `IERC4799NFT`, an interface implicitly implemented by virtually all popular NFT contracts, including all deployed contracts that are [ERC-721](./eip-721.md) compliant. This interface represents the essence of an NFT: a mapping from a token identifier to the address of a singular owner, represented by the function `ownerOf`.

davidbuckman · 2022-03-30T01:24:36Z

hey @SamWilsn, addressed those changes - what are next steps here?

SamWilsn

Nothing on your end, at least to get the draft merged!

…4800) * eip-4800 initial commit * Update EIPS/eip-4800.md * rename file * add discussions-to link * rework to designate ownership through a generic target token * include link to erc-721 * update abstract Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: isaacbuckman <isaacbuckman4@gmail.com>

eip-4800 initial commit

cf59d18

eth-bot added the newEIPFile label Feb 14, 2022

davidbuckman changed the title ~~EIP-4800 Non-Fungible Token Wrapping Standard~~ ERC-4800 Non-Fungible Token Wrapping Standard Feb 14, 2022

MicahZoltu reviewed Feb 15, 2022

View reviewed changes

EIPS/eip-4800.md Outdated Show resolved Hide resolved

Update EIPS/eip-4800.md

f10e95d

MicahZoltu reviewed Feb 15, 2022

View reviewed changes

EIPS/eip-4800.md Outdated Show resolved Hide resolved

cookingbooking1 approved these changes Feb 19, 2022

View reviewed changes

rename file

c15b6cb

davidbuckman changed the title ~~ERC-4800 Non-Fungible Token Wrapping Standard~~ ERC-4799 Non-Fungible Token Wrapping Standard Feb 23, 2022

add discussions-to link

280aae7

SamWilsn reviewed Feb 28, 2022

View reviewed changes

rework to designate ownership through a generic target token

cfd6aea

davidbuckman changed the title ~~ERC-4799 Non-Fungible Token Wrapping Standard~~ ERC-4799 Non-Fungible Token Ownership Designation Standard Mar 20, 2022

SamWilsn reviewed Mar 25, 2022

View reviewed changes

isaacbuckman added 2 commits March 25, 2022 19:41

include link to erc-721

e4e6c3b

update abstract

c91040c

SamWilsn approved these changes Apr 5, 2022

View reviewed changes

eth-bot added updateEIP and removed newEIPFile labels Apr 5, 2022

kodiakhq bot merged commit 6ba68e9 into ethereum:master Apr 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ERC-4799 Non-Fungible Token Ownership Designation Standard #4800

ERC-4799 Non-Fungible Token Ownership Designation Standard #4800

davidbuckman commented Feb 14, 2022

eth-bot commented Feb 14, 2022 •

edited

SamWilsn Feb 28, 2022

davidbuckman Mar 20, 2022

SamWilsn Feb 28, 2022

davidbuckman Mar 20, 2022

SamWilsn Feb 28, 2022

davidbuckman Mar 20, 2022

SamWilsn Feb 28, 2022

davidbuckman Mar 20, 2022

SamWilsn left a comment

SamWilsn Mar 25, 2022

isaacbuckman Mar 25, 2022

SamWilsn Mar 25, 2022

isaacbuckman Mar 25, 2022

SamWilsn Mar 25, 2022

isaacbuckman Mar 25, 2022

davidbuckman commented Mar 30, 2022

SamWilsn left a comment


		import "@openzeppelin/contracts/utils/introspection/IERC165.sol";

		interface IERCXNFT is IERC165 {


		## Security Considerations

		##### Long/Cyclical Chains of Ownership

	##### Long/Cyclical Chains of Ownership
	### Long/Cyclical Chains of Ownership


		## Backwards Compatibility

		The `IERC4799NFT` interface is backwards compatible with `IERC721`, as `IERC721` implicitly extends `IERC4799NFT`. This means that the ERC-4799 standard, which wraps NFTs that implement `ERC4799NFT`, is fully backwards compatible with ERC721.


		## Rationale

		To maximize the future compatibility of the wrapping contract, we first defined a canonical NFT interface. We created `IERC4799NFT`, an interface implicitly implemented by virtually all popular NFT contracts, including all deployed contracts that are ERC-721 compliant. This interface represents the essence of an NFT: a mapping from a token identifier to the address of a singular owner, represented by the function `ownerOf`.


		## Rationale

		####

ERC-4799 Non-Fungible Token Ownership Designation Standard #4800

ERC-4799 Non-Fungible Token Ownership Designation Standard #4800

Conversation

davidbuckman commented Feb 14, 2022

eth-bot commented Feb 14, 2022 • edited

All tests passed; auto-merging...

(pass) eip-4799.md

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SamWilsn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidbuckman commented Mar 30, 2022

SamWilsn left a comment

Choose a reason for hiding this comment

eth-bot commented Feb 14, 2022 •

edited