Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-4812: Exodus #4812

Closed
wants to merge 16 commits into from
Closed

Add EIP-4812: Exodus #4812

wants to merge 16 commits into from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 15, 2022

New EIP for a testing solution named Exodus.

== Initial comment
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot
Copy link
Collaborator

eth-bot commented Feb 15, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-4812.md

classification
newEIPFile

EIPS/eip-4804.md Outdated
title: Exodus
description: Exodus allows to create blockchain networks with accounts and transactions.
editors: Antoine Toulmé (@atoulme), Chaals Nevile (@chaals)
discussions-to: <https://entethalliance.org/contact>, For EEA members only (requires a patent commitment): <https://github.com/entethalliance/testing-wg/issues>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a link to a thread on the Ethereum Magicians forum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't intend to use the Ethereum Magicians forum for discussion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why? We nearly always use Ethereum Magicians for discussion, to keep all EIP discussion together, and to let us take backups in case something is removed from GitHub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think Sam's question is useful to answer and I'm also curious, all EIP discussions-to links must be to Ethereum Magicians.

EIPS/eip-4804.md Outdated Show resolved Hide resolved
EIPS/eip-4804.md Outdated Show resolved Hide resolved
EIPS/eip-4804.md Outdated Show resolved Hide resolved
EIPS/eip-4804.md Outdated Show resolved Hide resolved
EIPS/eip-4804.md Outdated Show resolved Hide resolved
EIPS/eip-4804.md Outdated Show resolved Hide resolved
EIPS/eip-4804.md Outdated Show resolved Hide resolved
EIPS/eip-4804.md Outdated Show resolved Hide resolved
EIPS/eip-4804.md Outdated
Comment on lines 32 to 38
The EEA is aiming to standardize Enterprise Ethereum clients, including facets like cross-chain activities and secure deployment of smart contracts. The Testing and Certification Working Group is working in earnest towards creating a test suite that allows developers to certify their implementation is matching the specification of the Enterprise Ethereum standard.

To do so, we require a way to generate workloads and situations on an enterprise blockchain that reconstitutes specific tests.

We have looked at existing solutions:
* Some clients are able to ingest RLP-encoded blockchain data for testing purposes, but that creates a burden on developers to maintain such data and is not directly viewable, making it difficult to maintain and discuss the data itself.
* Some clients can ingest specific payloads for components of their architecture, but we are looking to test consensus use cases that require all data such as transactions, accounts and balances.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rationale should explain why certain decisions were made, like why a particular constant was chosen, variable name picked, design followed, etc. The content currently here should be in the motivation, as it explains why someone would care about this standard.

@MicahZoltu
Copy link
Contributor

Normally we encourage people to create drafts and iterate on them, but there does need to be a lower bound on content I think to prevent number squatting. In this case, there is only a description of a problem and no solution so I'm hesitant to allow this to be merged as a draft as is since it has no specification at all.

atoulme and others added 9 commits April 16, 2022 22:27
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
@atoulme atoulme changed the title New EIP 4804 for Exodus [EIP 4812] for Exodus Apr 17, 2022
EIPS/eip-4812.md Outdated Show resolved Hide resolved
EIPS/eip-4812.md Outdated Show resolved Hide resolved
EIPS/eip-4812.md Show resolved Hide resolved
atoulme and others added 2 commits May 26, 2022 06:02
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
EIPS/eip-4812.md Show resolved Hide resolved
EIPS/eip-4812.md Outdated Show resolved Hide resolved
EIPS/eip-4812.md Outdated Show resolved Hide resolved
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@github-actions
Copy link

The commit 9cf1224 (as a parent of d4e14e6) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit 6f5505b (as a parent of 3019365) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit 3ec135b (as a parent of 29618cd) contains errors. Please inspect the Run Summary for details.

## Specification
The specification is hosted by the testing and client certification working group here:

https://entethalliance.github.io/testing-wg/#resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An EIP with an external specification section isn't much of an EIP, so I'm curious why you're linking out instead of putting the specification here?

EIPS/eip-4812.md Outdated
Some configurations **will** show security problems, to enable testing for them. This is a critical part of the functionality.

## License
Licensed under the [Apache License, version 2.0](https://www.apache.org/licenses/LICENSE-2.0.txt).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EIPs must be available under the Creative Commons Zero 1.0 license, so that they can be shared, implemented, and improved by the community as a whole.

There is some leeway for different licenses for reference implementations, but this is a hard rule for the EIP itself.

EIPS/eip-4812.md Outdated Show resolved Hide resolved
EIPS/eip-4812.md Outdated Show resolved Hide resolved
## Specification
The specification is hosted by the testing and client certification working group here:

https://entethalliance.github.io/testing-wg/#resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No external links

title: Exodus
description: Exodus facilitates the creation of blockchain networks with accounts and transactions.
author: Antoine Toulmé (@atoulme), Chaals Nevile (@chaals)
discussions-to: https://github.com/entethalliance/testing-wg/issues
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be on ethereum magicians.

@Pandapip1 Pandapip1 changed the title [EIP 4812] for Exodus Add EIP-4812: Exodus Sep 1, 2022
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Sep 1, 2022
@Pandapip1
Copy link
Member

Closing since the author hasn't been seen in >3 months (the stale threshold).

@Pandapip1 Pandapip1 closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants