Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-5083: NFT Token Acceptance Standard #5083

Conversation

mw2000
Copy link

@mw2000 mw2000 commented May 8, 2022

Created this PR to start an initial conversation if such an EIP would be useful to the community in general. Have built out the barebone structure of the EIP and will be adding more to it as I hear back from the community.

@eth-bot
Copy link
Collaborator

eth-bot commented May 8, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-5083.md

classification
newEIPFile

EIPS/eip-5071.md Outdated Show resolved Hide resolved
EIPS/eip-5071.md Outdated Show resolved Hide resolved
EIPS/eip-5071.md Outdated Show resolved Hide resolved
EIPS/eip-5071.md Outdated Show resolved Hide resolved
EIPS/eip-5071.md Outdated Show resolved Hide resolved
@abcoathup
Copy link
Contributor

Can you update the title of the PR to match the designated EIP number, e.g. EIP5083

1 similar comment
@abcoathup
Copy link
Contributor

Can you update the title of the PR to match the designated EIP number, e.g. EIP5083

EIPS/eip-5071.md Outdated Show resolved Hide resolved
EIPS/eip-5071.md Outdated
This standard allows contracts, such as NFTs that support [ERC-721](./eip-721.md) and [ERC-1155](./eip-1155.md) interfaces, to specify the permitted ERC20 tokens that can be used in a NFT marketplace to buy and sell the NFT from this collection. This would allow NFT creators to setup a wider economy by adding more use-cases to their own, or other ERC20 tokens. The interface would be similar to the [ERC-2981](./eip-2981.md) standard such that it will be completely voluntary for NFT marketplaces to implement this standard in their products.

## Motivation
Buy/Sell transactions for NFTs on marketplaces often happen in a standard currency like ETH. Certain NFT Collections may want to enable payments in specific ERC20 tokens only, howwever specifying this on each and every NFT Marketplace is cumbersome and creates friction. Instead, this EIP proposes the creation of a standard interface to allow NFT marketplaces to easily obtain this information from the smart contract itself.
Copy link
Contributor

@dtedesco1 dtedesco1 May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Buy/Sell transactions for NFTs on marketplaces often happen in a standard currency like ETH. Certain NFT Collections may want to enable payments in specific ERC20 tokens only, howwever specifying this on each and every NFT Marketplace is cumbersome and creates friction. Instead, this EIP proposes the creation of a standard interface to allow NFT marketplaces to easily obtain this information from the smart contract itself.
Transactions for NFT on marketplaces often happen in a standard currency like ETH. NFT collection developers may want to enable payments in only certain ERC20 tokens. Specifying this on each marketplace is cumbersome. EIP-5071 proposes a standard interface for NFT marketplaces to easily obtain this information from the smart contract itself.

@lightclient lightclient changed the title Create EIP-5071 : NFT Token Acceptance Standard Create EIP-5083 : NFT Token Acceptance Standard May 25, 2022
@Pandapip1
Copy link
Member

@mw2000 Please push an empty commit so that the new CI can run.

Co-authored-by: Micah Zoltu <micah@zoltu.net>
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Sep 1, 2022
@Pandapip1 Pandapip1 changed the title Create EIP-5083 : NFT Token Acceptance Standard Create EIP-5083: NFT Token Acceptance Standard Sep 1, 2022
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 16, 2022
@Pandapip1 Pandapip1 changed the title Create EIP-5083: NFT Token Acceptance Standard Add EIP-5083: NFT Token Acceptance Standard Sep 16, 2022
@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 17, 2022
@@ -0,0 +1,65 @@
---
eip: 5083
title: NFT Token Acceptance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the title and description I feel the "token acceptance" is a bit ambiguous. Can you reduce the ambiguity in the title to match the description?

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix all the CI errors

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Oct 14, 2022
@github-actions
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants