Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP5006: Change Status to Last Call #5204

Merged
merged 1 commit into from Jul 8, 2022
Merged

EIP5006: Change Status to Last Call #5204

merged 1 commit into from Jul 8, 2022

Conversation

emojidao
Copy link
Contributor

@emojidao emojidao commented Jul 6, 2022

EIP5006: Change Status to Last Call

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 6, 2022 •
edited

All tests passed; auto-merging...

(pass) eip-5006.md

classification
updateEIP
  • passed!

Pandapip1
Pandapip1 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pandapip1
Pandapip1 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come on @eth-bot...

@kodiakhq kodiakhq bot merged commit a3a3ec1 into ethereum:master Jul 8, 2022
@luyishisi
Copy link

Hello,
I found that this part of the contract has certain risks. SetUser lacks permission management, so that any user can modify any relationship. The user must override it before using it with peace of mind. Why is this part of the restriction no longer in the standard?

@Pandapip1
Copy link
Member

Hello,
I found that this part of the contract has certain risks. SetUser lacks permission management, so that any user can modify any relationship. The user must override it before using it with peace of mind. Why is this part of the restriction no longer in the standard?

Please submit a PR that fixes this.

@0xanders
Copy link
Contributor

Hello,
I found that this part of the contract has certain risks. SetUser lacks permission management, so that any user can modify any relationship. The user must override it before using it with peace of mind. Why is this part of the restriction no longer in the standard?

Please submit a PR that fixes this.

Thanks @Pandapip1 , just submitted a PR : #5304 (review)

@0xanders
Copy link
Contributor

Hello,
I found that this part of the contract has certain risks. SetUser lacks permission management, so that any user can modify any relationship. The user must override it before using it with peace of mind. Why is this part of the restriction no longer in the standard?

Thanks @luyishisi , we submitted a PR to fix this bug.

@emojidao emojidao deleted the 5006lastcall branch August 16, 2022 09:57
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@emojidao @0xanders @nachomazzara
EIP5006: Change Status to Last Call (ethereum#5204)
8e8e4d6 
Co-authored-by: Anders <anders@emojidao.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@0xanders 0xanders 0xanders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emojidao @eth-bot @luyishisi @Pandapip1 @0xanders