Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5000: Renumber to EIP-5159 #5270

Closed
wants to merge 2 commits into from

Conversation

SamWilsn
Copy link
Contributor

The EIP number was sniped using a bot. In order to discourage sniping,
we're renumbering the EIP to a less attractive number.

@SamWilsn SamWilsn mentioned this pull request Jul 15, 2022
The EIP number was sniped using a bot. In order to discourage sniping,
we're renumbering the EIP to a less attractive number.
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 15, 2022

File EIPS/eip-5159.md

Requires 1 more reviewers from @axic, @chfast, @hrkrshnn

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me

@MicahZoltu
Copy link
Contributor

MicahZoltu commented Jul 16, 2022

I am generally against this solution to the problem compared to #5255 because this basically does not punish the attacker for attempting the attack in any way. It essentially says, "you failed at the attack, but go ahead and try again next time because there is no punishment and the EIP editors will do the work of cleaning up your mess". If there was some reason to believe that this was an honest mistake or the person just didn't know the rules then I would be more lenient, but there is just a preponderance of evidence here that this was very intentional.

@SamWilsn
Copy link
Contributor Author

You, @MicahZoltu, are often fond of saying that editors are not curators, and that we should not put ourselves in a position to decide what is allowed in an EIP.

In this case, I would say that editors are not executioners, and that we should not (often) put ourselves in a position to punish non-editors for their actions. If the draft hadn't been merged, the obvious solution would've been to change the number in the PR before merging, as you've done before. As far as I am aware, merging wasn't @hrkrshnn's decision, and so they shouldn't be punished for it.

@SamWilsn
Copy link
Contributor Author

Regardless, I would like to resolve this quickly, to avoid creating any more confusion than necessary in the ecosystem.

If you would rather #5255 over this, I'll gladly approve it.

@MicahZoltu
Copy link
Contributor

I would say that editors are not executioners, and that we should not (often) put ourselves in a position to punish non-editors for their actions. If the draft hadn't been merged, the obvious solution would've been to change the number in the PR before merging, as you've done before. As far as I am aware, merging wasn't @hrkrshnn's decision, and so they shouldn't be punished for it.

I generally agree, we should not be punishing authors for bad behavior in most cases, especially if there is a plausible argument that they didn't know they were doing a bad thing. The editor involvement in this case though is what makes it cross the line for me from "user naively trying to play a silly game that they think doesn't matter" to "people in positions of power within the system attempting to capture and abuse that power".

@MicahZoltu
Copy link
Contributor

I have been thinking more on this and am coming around to this over #5255. If the rest of the editors all are in agreement on one or the other I'll go along with either, though I am still pretty strongly against doing nothing.

@Pandapip1
Copy link
Member

@MicahZoltu go ahead and merge.

@MicahZoltu
Copy link
Contributor

Since this is such a contentious issue (with editors being both for and against it, rather than neutral), I would like to get more editor consensus than just 3 of us before merging, or at the least discuss it in our fortnightly call.

At some point we may need to take action so this doesn't hold up progress on this EIP unnecessarily, but I am still hopeful that we can eventually reach some kind of agreement.

@Pandapip1
Copy link
Member

Nobody has disapproved of renumbering. The only objections have been to the deletion. We can merge this PR.

@MicahZoltu
Copy link
Contributor

Since it is such a contentious issue, and we haven't gotten approval from @lightclient or @axic, I would like to wait at least until we discuss it at the EIPIP meeting, if not longer. While I can certainly appreciate the desire to settle the matter, I am generally against rapidly moving forward under disagreement.

@Pandapip1 Pandapip1 changed the title Renumber EIP-5000 to eip-5159. Update EIP-5000: Renumber to EIP-5159. Aug 28, 2022
@Pandapip1 Pandapip1 changed the title Update EIP-5000: Renumber to EIP-5159. Update EIP-5000: Renumber to EIP-5159 Aug 28, 2022
@Pandapip1
Copy link
Member

Also CC @gcolvin

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 12, 2022
@Pandapip1
Copy link
Member

Still contentious.

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 13, 2022
@@ -1,5 +1,5 @@
---
eip: 5000
eip: 5159
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #5255, waiting for editor consensus....

@Pandapip1 Pandapip1 added the e-consensus Waiting on editor consensus label Sep 26, 2022
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Oct 11, 2022
@SamWilsn SamWilsn reopened this Aug 3, 2023
@SamWilsn SamWilsn requested a review from eth-bot as a code owner August 3, 2023 00:33
@eth-bot eth-bot added the a-review Waiting on author to review label Aug 3, 2023
@github-actions github-actions bot removed the w-stale Waiting on activity label Aug 4, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 19, 2023
@MicahZoltu
Copy link
Contributor

Not stale.

@lightclient
Copy link
Member

@MicahZoltu @SamWilsn do you have something new to contribute to this?

@MicahZoltu
Copy link
Contributor

Nothing new, but I also don't consider the issue resolved either. Your comments in #7396 and #7388 are concerning, but @Pandapip1 has already said what I would have said so I didn't feel the need to repeat.

@lightclient
Copy link
Member

It's kind of pointless to just leave this sitting here open. I had the right to number it as I did and I don't think it should be changed.

It feels more like you're spamming this repo by constantly bumping the issue with no further substance.

@MicahZoltu
Copy link
Contributor

My request is for the editors, as a group, to decide how to handle this issue. The impression I have is that there is not yet agreement on how to proceed with this, and even the future of how numbering will be handled still seems to be uncertain.

@github-actions github-actions bot removed the w-stale Waiting on activity label Aug 23, 2023
@abcoathup
Copy link
Contributor

TLDR: Number sniping not being penalized is unfair but it was not against the rules in EIP-1. This issue can be closed.
We should change the rules so this shouldn't happen again.


Number sniping was not allowed by convention prior to PR #5000 and EIP/ERCs with numbers being manually assigned.
This was not codified in EIP-1 which broadly allows editors to assign numbers prior to merging.

It is unfair to authors, both those who complied with convention and also those authors who number sniped & had a manual number assigned that PR #5000 was merged without the requested renumbering by an editor.
This went against convention but was not against the rules in EIP-1.

Proposed change to EIP-1 would codify that number sniping is not allowed: #7388
Once merged the situation ideally shouldn't happen again.

After much consideration, given this was within the rules, whilst I would prefer the EIP to be renumbered, the rules at the time mean that it was allowed. I think this issue can be closed.

I'd encourage the authors of #5000 to seek a new number so their EIP isn't tainted by this apparent unfairness.

@Pandapip1
Copy link
Member

@axic @gcolvin @SamWilsn can you confirm that this is indeed the consensus?

@xinbenlv
Copy link
Contributor

I second @abcoathup 's suggestion

@Pandapip1
Copy link
Member

Another thing worth noting - this EIP is getting close to becoming stagnant.

@SamWilsn
Copy link
Contributor Author

I've opened a formal Call for Input.

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 28, 2023
@MicahZoltu
Copy link
Contributor

Still active, waiting on resolution of ethcatherders/EIPIP#274.

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 29, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Oct 13, 2023
@MicahZoltu
Copy link
Contributor

Still waiting on ethcatherders/EIPIP#274

@github-actions github-actions bot removed the w-stale Waiting on activity label Oct 14, 2023
@SamWilsn
Copy link
Contributor Author

As mentioned in ethcatherders/EIPIP#274, the consensus is to not renumber EIP-5000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review e-consensus Waiting on editor consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants