-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EIP Bot #5400
Fix EIP Bot #5400
Conversation
A critical and unhandled exception has occurred: |
Head branch was pushed to by a user without write access
|
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, but I have no idea what's going on here 🤣
Head branch was pushed to by a user without write access
It can (and should) be tested against a fork of the EIPs repository. This is how alita did all of their testing before we merged bot changes previously. Out of curiosity, does anyone know why we don't just rely on GitHub's built in automerge feature entirely? It requires all checks pass I believe, so as long there is a bot to check for appropriate approvals (fails other ise) it feels like that should be good enough? |
There are some changes needed to be done in yours EIP fork: .github/workflows
I believe that automerge is not an option if You the Editors do not feel 100% comfortable with BOTs and/or Validators. Thats why I imaging there are so many open issues and, why we have been working to get an automatized working environment. |
We can test it (or at least try to). |
That is exactly what we're doing right now. |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
* Fix EIP-Bot CI * Add newline to CODEOWNERS * Make changes for testing * Test if GH Actions is a valid codeowner * It isn't allowed * Fix infinite loop * Do some tricks to avoid unneccesary extra runs * Fixing bug * Add Pandapip1-bot * Fix quotes * Another fix bites the dust * Another fix * Another thing * Use my testing fork * More fixes * Unpin while in dev * Add testing bot to codeowners * Is that the bug? * Try this fix * Quickfix * That was an easy fix * Remove Pandapip1-bot references * Update diff * Missed some * Pin to commit
This PR added me back as an editor. 😢 |
Sorry about that |
* Fix EIP-Bot CI * Add newline to CODEOWNERS * Make changes for testing * Test if GH Actions is a valid codeowner * It isn't allowed * Fix infinite loop * Do some tricks to avoid unneccesary extra runs * Fixing bug * Add Pandapip1-bot * Fix quotes * Another fix bites the dust * Another fix * Another thing * Use my testing fork * More fixes * Unpin while in dev * Add testing bot to codeowners * Is that the bug? * Try this fix * Quickfix * That was an easy fix * Remove Pandapip1-bot references * Update diff * Missed some * Pin to commit
Will need a manual merge, and the following branch protection settings will need to be updated:
Do these only AFTER this PR is merged.
NEEDS TESTING, BE READY TO REVERT THIS PR IF NEEDEDThis has been successfully E2E tested.Here's how it works: