Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5679: Move to Review #5692

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Update EIP-5679: Move to Review #5692

merged 2 commits into from
Sep 29, 2022

Conversation

xinbenlv
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Sep 20, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 20, 2022 •
edited

A critical exception has occurred:
Message: pr 5692 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

@poojaranjan poojaranjan mentioned this pull request Sep 20, 2022
Closed
SamWilsn
SamWilsn reviewed Sep 20, 2022
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EIP should be complete before moving to Review. Please flesh out the "Security Considerations" section.

@xinbenlv
Copy link
Contributor Author

Thanks @SamWilsn . I added the security consideration per your suggestion. Please take a look and see if it's good to merge now.

@Pandapip1 Pandapip1 changed the title Move EIP-5679 to Review Update EIP-5679: Move to Review Sep 20, 2022
@xinbenlv
Copy link
Contributor Author

@SamWilsn @Pandapip1 any other feedback before it can be merged?

@xinbenlv
Copy link
Contributor Author

Friendly ping~ @SamWilsn @Pandapip1

@eth-bot eth-bot enabled auto-merge (squash) September 29, 2022 00:55
@eth-bot eth-bot merged commit 90cc92d into ethereum:master Sep 29, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@xinbenlv @nachomazzara
Update EIP-5679: Move to Review (ethereum#5692)
0558640 
* Move EIP-5679 to Review

* Add security
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status s-review This EIP is in Review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xinbenlv @eth-bot @Pandapip1 @SamWilsn