Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-2135: Move to Last Call #5761

Closed
wants to merge 20 commits into from
Closed

Conversation

xinbenlv
Copy link
Contributor

@xinbenlv xinbenlv commented Oct 6, 2022

Creating a PR to accept revision suggestions before moving to last call

Will update last call deadline before merge

@xinbenlv xinbenlv requested a review from eth-bot as a code owner October 6, 2022 15:24
@github-actions github-actions bot added c-status Changes a proposal's status t-erc labels Oct 6, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 6, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-2135.md

classification
statusChange
  • eip-2135 state was changed from review to last call
  • This PR requires review from one of [@axic, @SamWilsn, @Pandapip1]

@xinbenlv xinbenlv changed the title Erc2135 EIP-2135 Move to Laat Call Oct 6, 2022
@xinbenlv xinbenlv changed the title EIP-2135 Move to Laat Call EIP-2135 Move to Last Call Oct 6, 2022
@xinbenlv xinbenlv changed the title EIP-2135 Move to Last Call EIP-2135: Move to Last Call Oct 6, 2022
@Pandapip1 Pandapip1 changed the title EIP-2135: Move to Last Call Update EIP-2135: Move to Last Call Oct 6, 2022
@xinbenlv xinbenlv changed the title Update EIP-2135: Move to Last Call Move to Last Call: EIP-2135: Consumable Interface Oct 15, 2022
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Abstract is a bit light on details. Could maybe define what "consume" means, who is doing the consuming, etc.
  • consumaed is not a word.
  • Motivation section doesn't do a good job convincing me that we need an ERC for this (though it does touch on it.) As an example of the content I'd like to see, maybe mention what you'd expect wallets to do with this information? Maybe NFT marketplaces too (say displaying consumed tokens separately from unconsumed ones)?
  • Clarify whether consume burns the token. Right now it sounds like a compliant consume is allowed to not transfer ownership to the zero address, as long as it emits the event.
  • Please remove the external links to goerli in the Reference Implementation section. If you'd like to include a reference implementation, please put it in this EIP's assets directory.
  • Recommending an audit is good advice, but I think it applies to basically every EIP 🤣 You should imagine the Security Considerations section as a list of specific things that auditors should pay attention to for this EIP and not as generic advice to smart contract developers.

@Pandapip1 Pandapip1 changed the title Move to Last Call: EIP-2135: Consumable Interface Update EIP-2135: Move to Last Call Oct 23, 2022
@xinbenlv
Copy link
Contributor Author

Working on addressing @SamWilsn 's question

@xinbenlv xinbenlv marked this pull request as draft October 31, 2022 21:08
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 8, 2022
@xinbenlv
Copy link
Contributor Author

xinbenlv commented Dec 8, 2022

Still an issue

@github-actions github-actions bot removed the w-stale Waiting on activity label Dec 10, 2022
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 26, 2022
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status t-erc w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants