-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-2135: Move to Last Call #5761
Conversation
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) eip-2135.md
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Abstract is a bit light on details. Could maybe define what "consume" means, who is doing the consuming, etc.
consumaed
is not a word.- Motivation section doesn't do a good job convincing me that we need an ERC for this (though it does touch on it.) As an example of the content I'd like to see, maybe mention what you'd expect wallets to do with this information? Maybe NFT marketplaces too (say displaying consumed tokens separately from unconsumed ones)?
- Clarify whether
consume
burns the token. Right now it sounds like a compliantconsume
is allowed to not transfer ownership to the zero address, as long as it emits the event. - Please remove the external links to goerli in the Reference Implementation section. If you'd like to include a reference implementation, please put it in this EIP's
assets
directory. - Recommending an audit is good advice, but I think it applies to basically every EIP 🤣 You should imagine the Security Considerations section as a list of specific things that auditors should pay attention to for this EIP and not as generic advice to smart contract developers.
Working on addressing @SamWilsn 's question |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
Still an issue |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
Creating a PR to accept revision suggestions before moving to last call
Will update last call deadline before merge