Update EIP-5615: Move to Review

[Pandapip1]

Makes a few clarifications as well

[eth-bot]

A critical exception has occurred:
Message: pr 5778 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

[xinbenlv]

I think it's ok to move to Review. I'd love to hear more rationale of the choice of exists() method and alternatives that has been considered.

A separate note: while I personally think this is an useful EIP, and I disagree with the "suggestions" in determining whether something worth a EIP, made in #5737, I like to hear @fulldecent 's thought on how the suggestions will evaluate this particular EIP, putting that suggestion into tests with real world EIPs

[fulldecent]

As per #5737, I expect the author here should cite some people that are using this already. At a minimum this should be in the official discussion record.

They started that by saying it is an OZ contract. But it would be nice if they actually did the work of going and finding some live implementations.

In addition to find some people implementing the producer of this function, they should also go find and documentation that is usefully querying this information.

Yes, this might even take a few minutes of time! But the goal here is to publish useful, helpful things, not just find the remaining function names in 4bytes, put your name on it, and "earn" one of the remaining 5,000 EIP numbers.

[Pandapip1]

As per #5737, I expect the author here should cite some people that are using this already. At a minimum this should be in the official discussion record.

I'll add a few relevant links. I don't think this should necessarily be included in the EIP itself, but the linking in the discussion thread is a no-brainer.

OpenSea supports both of these functions. This is undocumented but is clear from their example repository. It's also noted in the first thread I just linked to. I don't know whether to mention this or not. I'm leaning slightly towards no (it's undocumented!) but my mind can be easily changed on this.

OpenZeppelin, of course, has an implementation of this, as noted in the EIP itself.

I don't see an easy way to track support for this for deployed contracts.

[fulldecent]

@Pandapip1 cool reference. 1155 requires strict token reporting so totalsupply function should be duplicative of the token transfers. If OS does not say they are using this function to collect data for their production website we should assume they are not using it

[Pandapip1]

If OS does not say they are using this function to collect data for their production website we should assume they are not using it

OpenSea doesn't have any documentation about support for EIP-1155 at all, except for a page in the sidebar with a "documentation soon™." It's well-known that OS supports EIP-1155, though.

[Pandapip1]

It would be nice if someone from @ProjectOpenSea could weigh in.

[Pandapip1]

That did not work :|

[Pandapip1]

There we are.