Add EIP-5883: Token Transfer by Social Recovery #5883

wsdt · 2022-11-06T10:24:39Z

title: Token Transfer by Social Recovery

description: This EIP describes a token recovery by a transfer from an identity which is not accessible anymore to another newly created identity by social interaction.

Looking forward to feedback!

eth-bot · 2022-11-06T10:25:28Z

All reviewers have approved. Auto merging...

abcoathup · 2022-11-07T23:26:59Z

I couldn't see where an EIP editor assigned the EIP 5807?
I assume this EIP should be EIP5882 as that was the original PR (unclear why #5882 was closed)

EIPS/eip-5807.md

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

wsdt · 2022-11-09T09:42:57Z

Does anybody know why the HTMLProofer fails, receiving this error

Liquid Exception: Liquid syntax error (line 33): Variable '{{{\displaystyle\sum_{i = 1}' was not properly terminated with regexp: /\}\}/ in EIPS/eip-5883.md

That would be in the middle of the code snippet.

mrqc · 2022-11-13T15:58:47Z

We checked the markdown linter issues for now. The html proofer seems to be wrong.

Pandapip1 · 2022-11-16T14:28:26Z

HTMLproofer is not wrong. Make sure that you escape any {{ or }}.

wsdt · 2022-11-16T15:59:51Z

Should be fine now, thanks everyone!

[@axic, @SamWilsn, @Pandapip1]

EIPS/eip-5883.md

wsdt · 2022-11-25T14:21:01Z

When does the eth-bot review the PR? Is there something else to be done?
Thank you in advance!

[@axic, @SamWilsn, @Pandapip1, @eth-bot ]

EIPS/eip-5883.md

github-actions · 2023-01-11T00:17:55Z

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

wsdt · 2023-01-11T07:10:55Z

Ping - any chance to get this to Draft? Are we missing something?

SamWilsn · 2023-01-31T01:04:03Z

There's still a few outstanding comments. Most importantly about the Rationale section.

wsdt · 2023-01-31T10:29:15Z

Fixed, sorry overlooked them!
Thanks @SamWilsn

wsdt · 2023-02-05T21:19:30Z

@eth-bot

wsdt · 2023-02-15T17:12:27Z

anything missing? Would appreciate an update, thank you :-)

Pandapip1

LGTM. You might have outdated CI - I recommend rebasing your branch (and not using your fork's master branch to submit PRs!)

* EIP - Social Recovery * delimiter * Social Recovery - Validation errors fix * Update EIPS/eip-5807.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * EIP 5883 - fixing validation errors * final validation errors fixed - EIP 5883 * Update eip-5883.md * Fix Markdown linter * Update eip-5883.md * Update eip-5883.md * Update eip-5883.md * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * applied feedback - 5883 * Fixing comments. --------- Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

EIP - Social Recovery

5e4e774

wsdt requested a review from eth-bot as a code owner November 6, 2022 10:24

wsdt added 2 commits November 6, 2022 11:27

delimiter

edf3c2a

Social Recovery - Validation errors fix

2dbdf4e

SamWilsn reviewed Nov 9, 2022

View reviewed changes

EIPS/eip-5807.md Outdated Show resolved Hide resolved

Dankyybomb1 previously approved these changes Nov 9, 2022

View reviewed changes

Update EIPS/eip-5807.md

226e8db

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

wsdt dismissed Dankyybomb1’s stale review via 226e8db November 9, 2022 08:43

wsdt added 2 commits November 9, 2022 09:53

EIP 5883 - fixing validation errors

a90abbf

final validation errors fixed - EIP 5883

85ff6da

github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Nov 9, 2022

Pandapip1 changed the title ~~EIP - Social Recovery~~ Add EIP-5883: Token Transfer by Social Recovery Nov 9, 2022

poojaranjan mentioned this pull request Nov 15, 2022

EIP Editing Office Hour Meeting 6 ethcatherders/EIPIP#188

Closed

wsdt added 3 commits November 16, 2022 16:40

Update eip-5883.md

ca5d708

Fix Markdown linter

79c9224

Update eip-5883.md

e152a5f

xinbenlv reviewed Nov 19, 2022

View reviewed changes

EIPS/eip-5883.md Show resolved Hide resolved

wsdt added 2 commits November 20, 2022 21:39

Update eip-5883.md

052cede

Update eip-5883.md

b2e54a7

SamWilsn reviewed Nov 25, 2022

View reviewed changes

EIPS/eip-5883.md Outdated Show resolved Hide resolved

fix merge conflict

5f580f2

poojaranjan mentioned this pull request Nov 29, 2022

EIP Editing Office Hour Meeting 7 ethcatherders/EIPIP#194

Closed

poojaranjan mentioned this pull request Dec 12, 2022

EIP Editing Office Hour Meeting 8 ethcatherders/EIPIP#197

Closed

wsdt mentioned this pull request Dec 19, 2022

EIP Editing Office Hour Meeting 9 ethcatherders/EIPIP#201

Closed

12 tasks

github-actions bot added the w-stale Waiting on activity label Jan 11, 2023

github-actions bot removed the w-stale Waiting on activity label Jan 16, 2023

ethereum deleted a comment Jan 31, 2023

Fixing comments.

11f3be9

wsdt dismissed a stale review via 11f3be9 January 31, 2023 10:28

wsdt requested review from SamWilsn, xinbenlv and Dankyybomb1 and removed request for SamWilsn and xinbenlv February 1, 2023 19:03

poojaranjan mentioned this pull request Feb 7, 2023

EIP Editing Office Hour Meeting 11 ethcatherders/EIPIP#207

Closed

27 tasks

Pandapip1 approved these changes Feb 24, 2023

View reviewed changes

eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Feb 24, 2023

eth-bot enabled auto-merge (squash) February 24, 2023 19:02

eth-bot approved these changes Feb 24, 2023

View reviewed changes

eth-bot merged commit 8dd93a9 into ethereum:master Feb 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP-5883: Token Transfer by Social Recovery #5883

Add EIP-5883: Token Transfer by Social Recovery #5883

wsdt commented Nov 6, 2022

eth-bot commented Nov 6, 2022 •

edited

Loading

abcoathup commented Nov 7, 2022

wsdt commented Nov 9, 2022

mrqc commented Nov 13, 2022

Pandapip1 commented Nov 16, 2022

wsdt commented Nov 16, 2022

wsdt commented Nov 25, 2022

github-actions bot commented Jan 11, 2023

wsdt commented Jan 11, 2023

SamWilsn commented Jan 31, 2023

wsdt commented Jan 31, 2023

wsdt commented Feb 5, 2023

wsdt commented Feb 15, 2023

Pandapip1 left a comment •

edited

Loading

Add EIP-5883: Token Transfer by Social Recovery #5883

Add EIP-5883: Token Transfer by Social Recovery #5883

Conversation

wsdt commented Nov 6, 2022

eth-bot commented Nov 6, 2022 • edited Loading

abcoathup commented Nov 7, 2022

wsdt commented Nov 9, 2022

mrqc commented Nov 13, 2022

Pandapip1 commented Nov 16, 2022

wsdt commented Nov 16, 2022

wsdt commented Nov 25, 2022

github-actions bot commented Jan 11, 2023

wsdt commented Jan 11, 2023

SamWilsn commented Jan 31, 2023

wsdt commented Jan 31, 2023

wsdt commented Feb 5, 2023

wsdt commented Feb 15, 2023

Pandapip1 left a comment • edited Loading

Choose a reason for hiding this comment

eth-bot commented Nov 6, 2022 •

edited

Loading

Pandapip1 left a comment •

edited

Loading