Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master into eip-5380-review #6215

Merged
merged 17 commits into from
Dec 25, 2022
Merged

Merge master into eip-5380-review #6215

merged 17 commits into from
Dec 25, 2022

Conversation

Pandapip1
Copy link
Member

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

mkalinin and others added 17 commits December 20, 2022 13:53
@mkalinin @djrtwo
Add EIP-6110: Supply validator deposits on chain (#6110)
047f16d 
* EIP-6110: initial draft

* Fix header

* Fill out the discussions-to

* Make linter happy

* Fix color schema for python snippets

* Apply suggestions from code review

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>

* Fix anchor

* Fix eip4881 link

* Fix eip4881 link once again

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
@Pandapip1
Update EIP-5507: Fix typo (wei is a reserved name) (#6191)
220fbe2
@lightclient @gumb0
@jochem-brouwer @chfast @shemnon
3540,4570,5450: update EOF container format (#6156)
f29a424 
* 3540: update eof contain format

* 4750,5450: update for new 3540 changes, disallow unreachble code

* 4750,5450: remove ref impls for now

* appease our overlord, walidator

* Apply suggestions from code review

Co-authored-by: Andrei Maiboroda <andrei@ethereum.org>
Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>

* reword type section intro

Co-authored-by: Paweł Bylica <chfast@gmail.com>

* apply feedback from review

Co-authored-by: Paweł Bylica <chfast@gmail.com>

* 4750: do not cleanup stack after jumpf or retf

* remove rationale for stack cleanup

* Apply suggestions from code review

Co-authored-by: Paweł Bylica <chfast@gmail.com>

* 4750: remove jumpf for later definition

* fix stale comment

Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* fix a couple typos and improve clarity

* appease link checker

* note terminating instruction requirement from 5450

* cap max_stack_height at 1023

* add padding to table

* fix padding

Co-authored-by: Andrei Maiboroda <andrei@ethereum.org>

* revert terminating instructions change to 3670

* fix rearranged sections

Co-authored-by: Andrei Maiboroda <andrei@ethereum.org>

* Apply suggestions from code review

Co-authored-by: Paweł Bylica <chfast@gmail.com>

Co-authored-by: Andrei Maiboroda <andrei@ethereum.org>
Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
Co-authored-by: Paweł Bylica <chfast@gmail.com>
Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@steven2308 @ThunderDeliverer
Fixes bug when replacing asset on sample implementation of 5773 (#6202)
2f369da 
* Fixes bug when replacing asset on sample implementation of 5773.

* Rename the smart contract in specification

The smart contract specification was renamed to be identic to the name
of the proposal. This has been done so that the assets changes can be
merged.

Co-authored-by: Jan Turk <jan.turk12@gmail.com>
@chfast @lightclient
4750,5450: Specify stack overflow check only in CALLF (#6205)
6f1bac8 
* 4750,5450: Specify stack overflow check only in CALLF

* Apply suggestions from code review

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
@lightclient @Pandapip1
Add EIP-6206: EOF - JUMPF instruction (#6206)
accf816 
* add jumpf eip

* add eip number and discussion link

* Fix markdownlint errors

* Last markdownlint error

* Fix invalid link

* Formatting stuff

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@ayobuenavista
Update EIP-5115: Updates to interface based on community feedback (#6207
dc7f434 
)

* Update EIP-5115: Changes based from community feedback

* Update EIP-5115: Changes in interface and definitions

* Update EIP-5115: Linting fixes
@ayobuenavista
Update EIP-5115: Minor correction on interface (#6208)
d64f4c0
@leekt
Update eip-4337.md : typo desribed -> described (#6169)
4edf0d1
@lightclient
clarify that initcode which fails validation still pays 3860 initcode…
83beeb2 
… cost (#6210)
@lightclient
remove pc instruction from eof (#6209)
4e5cd9f
@sujithsomraaj @Pandapip1 @mattstam
Add EIP-6170: Cross-Chain Messaging Interface (#6172)
af8847d 
* cross-chain messaging interface

* fix: markdown linter fix

* chore: updating EIP name

* Apply suggestions from code review

* chore: changing specification to natspec interface

* Update eip-6170.md

Co-authored-by: Matt Stam <mattstam@live.com>

* Update eip-6170.md

* Update eip-6170.md

* chore: remove events to discuss further

* Move file to correct folder

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Matt Stam <mattstam@live.com>
@chfast
Ignore JetBrains project files (#6211)
63e9f33
@Pandapip1
Update EIP-5568: Move to review (#6177)
95381a5
@gaurangtorvekar @SamWilsn
Update EIP-5606: Move to Last Call (#6151)
f5d58e6 
* Update EIP-5606: Moving to Last Call

* Update EIP-5606: Added Last Call Deadline

* Update EIP-5606: Fixed a typo

* Update EIPS/eip-5606.md

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@Pandapip1
Update EIP-5219: Move to review (#6180)
aa2ffec 
* Update EIP-5219: Move to review

* Merge master into eip-5219-review (#6183)

* Update EIP-5507: Add Rationale stub (#6181)

* Update EIP-5219: Fix small typo (#6182)
@Pandapip1
Update EIP-5380: Second Revision (#6214)
4943a9e
@Pandapip1 Pandapip1 merged commit 4acd66b into eip-5380-review Dec 25, 2022
@github-actions github-actions bot added c-new Creates a brand new proposal c-update Modifies an existing proposal s-draft This EIP is a Draft s-review This EIP is in Review t-core t-erc t-interface labels Dec 25, 2022
@abcoathup
Copy link
Contributor

@Pandapip1 can you remove c-new label as it isn't a new EIP

@Pandapip1 Pandapip1 removed c-new Creates a brand new proposal c-update Modifies an existing proposal t-core labels Dec 27, 2022
@Pandapip1 Pandapip1 removed t-erc t-interface s-draft This EIP is a Draft s-review This EIP is in Review labels Dec 27, 2022
@Pandapip1
Copy link
Member Author

Pandapip1 commented Dec 27, 2022 •
edited
Loading

@Pandapip1 can you remove c-new label as it isn't a new EIP

I mean... it does add new EIPs wrt the target branch of this PR.

@abcoathup
Copy link
Contributor

abcoathup commented Dec 27, 2022 •
edited
Loading

I use the c-new label to find new EIPs, though appreciate this may not be the purpose of the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot Awaiting requested review from eth-bot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@Pandapip1 @abcoathup @mkalinin @lightclient @steven2308 @chfast @ayobuenavista @leekt @sujithsomraaj @gaurangtorvekar