Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-6220: Propose Composable NFTs utilizing Equippable Parts #6220

Merged
merged 11 commits into from
Jan 20, 2023

Conversation

ThunderDeliverer
Copy link
Contributor

This EIP draft proposal includes RMRK team's work on developing an NFT standard where an NFT can can equip fixed and slot parts and in turn equip NFTs into slot parts.

Proposed an interface for Composable non-fungible tokens through fixed
and slot parts equipping.
@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-erc labels Dec 27, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 27, 2022

A critical exception has occurred:
Message: pr 6220 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

Assigned EIP number based on proposal PR number. This is following past
experience, but can easily be changed if requested by EIP editors.
@github-actions github-actions bot removed the e-number Waiting on EIP Number assignment label Dec 27, 2022
@ThunderDeliverer ThunderDeliverer changed the title Propose Composable NFTs utilizing Equippable Parts EIP-6220: Propose Composable NFTs utilizing Equippable Parts Dec 27, 2022
@Pandapip1 Pandapip1 changed the title EIP-6220: Propose Composable NFTs utilizing Equippable Parts Add EIP-6220: Propose Composable NFTs utilizing Equippable Parts Jan 4, 2023
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases/reference implementation are too complete. Please get rid of the package/config/dependency files.

@steven2308
Copy link
Contributor

The test cases/reference implementation are too complete. Please get rid of the package/config/dependency files.

I removed the not vital configuration files. Just package.json and hardhat.config.ts left.

@ThunderDeliverer
Copy link
Contributor Author

@Pandapip1 would you mind taking a look at the changes since your review. We addressed the completeness of the implementation and would love to move forward with the EIP process.

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review wasn't submitted. These changes must be made before Review, but for now, I think this is okay for a draft.

EIPS/eip-6220.md Show resolved Hide resolved
EIPS/eip-6220.md Show resolved Hide resolved
@eth-bot eth-bot enabled auto-merge (squash) January 20, 2023 17:33
@eth-bot eth-bot merged commit 7468965 into ethereum:master Jan 20, 2023
@ThunderDeliverer
Copy link
Contributor Author

Thank you for submitting your review. The requested changes were applied in the #6369

iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
…ereum#6220)

* Propose Composable NFTs utilizing Equippable Parts

Proposed an interface for Composable non-fungible tokens through fixed
and slot parts equipping.

* Assign EIP number

Assigned EIP number based on proposal PR number. This is following past
experience, but can easily be changed if requested by EIP editors.

* Add discussion URI

* Fix links to test cases

* Add a single trailing newline to the proposal

* Updated and expanded the proposal

* Slightly refined Abstract

* Additional refinements

* Fix formatting of ordered list in Rationale

* Removes configuration files and simplifies package.json.

* EIP-6220: Leaves only minimal needed packages to compile and run tests.

Co-authored-by: steven2308 <steven2308@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants