-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-6220: Propose Composable NFTs utilizing Equippable Parts #6220
Conversation
Proposed an interface for Composable non-fungible tokens through fixed and slot parts equipping.
A critical exception has occurred: |
Assigned EIP number based on proposal PR number. This is following past experience, but can easily be changed if requested by EIP editors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test cases/reference implementation are too complete. Please get rid of the package/config/dependency files.
I removed the not vital configuration files. Just |
@Pandapip1 would you mind taking a look at the changes since your review. We addressed the completeness of the implementation and would love to move forward with the EIP process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review wasn't submitted. These changes must be made before Review, but for now, I think this is okay for a draft.
Thank you for submitting your review. The requested changes were applied in the #6369 |
…ereum#6220) * Propose Composable NFTs utilizing Equippable Parts Proposed an interface for Composable non-fungible tokens through fixed and slot parts equipping. * Assign EIP number Assigned EIP number based on proposal PR number. This is following past experience, but can easily be changed if requested by EIP editors. * Add discussion URI * Fix links to test cases * Add a single trailing newline to the proposal * Updated and expanded the proposal * Slightly refined Abstract * Additional refinements * Fix formatting of ordered list in Rationale * Removes configuration files and simplifies package.json. * EIP-6220: Leaves only minimal needed packages to compile and run tests. Co-authored-by: steven2308 <steven2308@outlook.com>
This EIP draft proposal includes RMRK team's work on developing an NFT standard where an NFT can can equip fixed and slot parts and in turn equip NFTs into slot parts.