Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5018: Move to Review #6443

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Update EIP-5018: Move to Review #6443

merged 4 commits into from
Feb 8, 2023

Conversation

qizhou
Copy link
Contributor

@qizhou qizhou commented Feb 5, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@qizhou qizhou requested a review from eth-bot as a code owner February 5, 2023 07:00
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Feb 5, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 5, 2023 •
edited
Loading

All tests passed; auto-merging...

(pass) eip-5018.md

classification
updateEIP
  • passed!

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 5, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

The commit 75ec08e (as a parent of 6d44507) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 6, 2023
@qizhou qizhou mentioned this pull request Feb 6, 2023
Closed
27 tasks
SamWilsn
SamWilsn reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the "write", "read", and other headings under "Methods" be one level deeper (i.e. #####)?

Otherwise, I think this looks good to move to review.

@qizhou
Copy link
Contributor Author

qizhou commented Feb 7, 2023

Should the "write", "read", and other headings under "Methods" be one level deeper (i.e. #####)?

Otherwise, I think this looks good to move to review.

Done. Many thanks for the comment.

@Pandapip1 Pandapip1 changed the title Update eip-5018.md Update EIP-5018: Move to Review Feb 8, 2023
Pandapip1
Pandapip1 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eth-bot eth-bot enabled auto-merge (squash) February 8, 2023 14:08
@eth-bot eth-bot merged commit 516e62e into ethereum:master Feb 8, 2023
iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
@qizhou @iseriohn
Update EIP-5018: Move to Review (ethereum#6443)
006d1b7 
* Update eip-5018.md

* Update eip-5018.md

* Update eip-5018.md

* Update eip-5018.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status s-review This EIP is in Review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qizhou @eth-bot @Pandapip1 @SamWilsn