Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-6493: SSZ Transaction Signature Scheme #6493

Merged
merged 10 commits into from Feb 26, 2023

Commits on Feb 10, 2023

  1. Update EIP-4844: hash_tree_root based transaction hashes

    This PR builds on top of prior work from:
    - @lightclient at ethereum#6385
    
    The signature malleability issue in the original PR is addressed by
    reusing the consensus `compute_signing_root` mechanism to link each
    hash with the transaction's underlying `chain_id` and `tx_type`.
    
    Note that this makes the transaction hashes different from the plain
    `hash_tree_root` values. This means that if the `transactions_root` MPT
    is replaced with SSZ (EIP-6404), that the `transaction_hash` would need
    to be tracked separately, same as for legacy RLP-based transactions.
    This is mainly a cosmetic issue, not a practical one. In an SSZ tx tree,
    we could simply include both the HTR as well as the perpetual tx hash.
    
    Cryptographic analysis may be necessary to determine the amount by which
    the hash collision probability is increased, if we use different hashing
    algorithms for transactions. On the other hand, using different algo for
    SSZ transactions reduces the impact of a custom network defining 0x05 as
    a RLP transaction that might serialize same as the blob SSZ transaction.
    etan-status committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    0910fa8 View commit details
    Browse the repository at this point in the history
  2. Fix signed_tx_hash

    etan-status committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    4e8c2ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b949308 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Configuration menu
    Copy the full SHA
    e279273 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Configuration menu
    Copy the full SHA
    1e9e198 View commit details
    Browse the repository at this point in the history
  2. Add URL

    etan-status committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    619be29 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f77c446 View commit details
    Browse the repository at this point in the history
  4. Fix

    etan-status committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    d17e078 View commit details
    Browse the repository at this point in the history
  5. rm redundant test

    etan-status committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    0b5012c View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Apply most of @g11tech's review

    Co-authored-by: g11tech <develop@g11tech.io>
    Pandapip1 and g11tech committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    b322bc6 View commit details
    Browse the repository at this point in the history