New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-6493: SSZ Transaction Signature Scheme #6493
Merged
Merged
Commits on Feb 10, 2023
-
Update EIP-4844:
hash_tree_root
based transaction hashesThis PR builds on top of prior work from: - @lightclient at ethereum#6385 The signature malleability issue in the original PR is addressed by reusing the consensus `compute_signing_root` mechanism to link each hash with the transaction's underlying `chain_id` and `tx_type`. Note that this makes the transaction hashes different from the plain `hash_tree_root` values. This means that if the `transactions_root` MPT is replaced with SSZ (EIP-6404), that the `transaction_hash` would need to be tracked separately, same as for legacy RLP-based transactions. This is mainly a cosmetic issue, not a practical one. In an SSZ tx tree, we could simply include both the HTR as well as the perpetual tx hash. Cryptographic analysis may be necessary to determine the amount by which the hash collision probability is increased, if we use different hashing algorithms for transactions. On the other hand, using different algo for SSZ transactions reduces the impact of a custom network defining 0x05 as a RLP transaction that might serialize same as the blob SSZ transaction.
Configuration menu - View commit details
-
Copy full SHA for 0910fa8 - Browse repository at this point
Copy the full SHA 0910fa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e8c2ac - Browse repository at this point
Copy the full SHA 4e8c2acView commit details -
Configuration menu - View commit details
-
Copy full SHA for b949308 - Browse repository at this point
Copy the full SHA b949308View commit details
Commits on Feb 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e279273 - Browse repository at this point
Copy the full SHA e279273View commit details
Commits on Feb 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1e9e198 - Browse repository at this point
Copy the full SHA 1e9e198View commit details -
Configuration menu - View commit details
-
Copy full SHA for 619be29 - Browse repository at this point
Copy the full SHA 619be29View commit details -
Configuration menu - View commit details
-
Copy full SHA for f77c446 - Browse repository at this point
Copy the full SHA f77c446View commit details -
Configuration menu - View commit details
-
Copy full SHA for d17e078 - Browse repository at this point
Copy the full SHA d17e078View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b5012c - Browse repository at this point
Copy the full SHA 0b5012cView commit details
Commits on Feb 26, 2023
-
Apply most of @g11tech's review
Co-authored-by: g11tech <develop@g11tech.io>
Configuration menu - View commit details
-
Copy full SHA for b322bc6 - Browse repository at this point
Copy the full SHA b322bc6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.